`IncompatibleSdkVersionException` thrown on startup
yoshiask opened this issue · comments
Describe the bug
I just cloned the repo and installed the app for the first time, but whenever I go through the OOBE and set up a new core, the core remains unloaded and the app remains on its splash screen indefinitely. Checking the logs and stepping through with a debugger reveals that the SDK version compatibility check fails on a freshly created core.
The check is performed by MergedCore
's constructor:
strix-music/src/Sdk/StrixMusic.Sdk/AdapterModels/MergedCore.cs
Lines 42 to 43 in 5663129
Somehow the core metadata's SdkVer
is set to 0.0.0.0
, while the current SDK version is 0.0.2.0
.
Affected area
- Strix Music SDK
- Strix Music App
Regression
No response
Steps to reproduce
1. Install and launch app
2. Set up local files core
3. Relaunch app
4. Observe that app gets stuck on loading screen, with local files core on "Unloaded"
Visual repro steps
No response
Expected behavior
The SDK version specified in core metadata should match the version of the SDK it is dependent on.
Additional context
No response
Help us help you
Yes, but only if others can assist.
Thanks @yoshiask. It looks like we were hardcoding the SDK version number in the LocalFilesCore and OneDriveCore instead of using the actual assembly number.
Problem code can be found here:
Instead, we should be using typeof(ICore).Assembly.GetName().Version
Alright, that's a simple fix. If you're not already doing it, you can assign this to me and I'll open a PR.