Cancelling core configuration in OOBE causes crash

Question

Cancelling core configuration in OOBE causes crash

yoshiask opened this issue 2 years ago · comments

Joshua "Yoshi" Askharoun commented 2 years ago

Describe the bug

Attempting to cancel the setup of a new core during the OOBE causes the app to crash with a TaskCanceledException.

Affected area

Strix Music SDK
Strix Music App

Regression

No response

Steps to reproduce

1. Open a fresh install of Strix Music
2. In the Services tab of the OOBE, add a OneDrive core
3. Click "OK"
4. Click "Cancel"
5. Observe app crash

Visual repro steps

No response

Expected behavior

The OOBE should gracefully cancel setup of the selected core.

Additional context

No response

Help us help you

Yes, but only if others can assist.

Arlo · Answer 1 · Wed Jun 01 2022 18:48:22 GMT+0800 (China Standard Time)

It looks like when we did #99, we forgot to put back cancellation handling. This should be as easy as wrapping the ICore.InitAsync calls in a try/catch for OperationCanceledException.