Incorrect folder check in SystemFolderWatcher

[Joshua "Yoshi" Askharoun]

The problem

OwlCore.Storage/src/SystemIO/SystemFolderWatcher.cs

Line 114 in 7efe338

 private static bool IsFolder(string path) => path.TrimEnd(Path.PathSeparator, Path.DirectorySeparatorChar, Path.AltDirectorySeparatorChar) == Path.GetDirectoryName(path); 

This method appears to check if a given path is a folder by stripping any trailing slashes and comparing that to Path.GetDirectoryName(path). Because Path.GetDirectoryName returns the path to the parent directory, this check will sometimes fail even for folders. For example:

Note this test will pass if the path does have a trailing slash, since in that case Path.GetDirectoryName will effectively return the root of an arbitrary subdirectory in the given path, which of course is always the original path.

The solution

The only reliable way to check if a path is folder is by asking the filesystem, calling Directory.Exists(path) like this:

OwlCore.Storage/src/SystemIO/SystemFolder.cs

Line 236 in 7efe338

 private static bool IsFolder(string path) => Directory.Exists(path); 

Remarks

The IsFile check has a similar issue; it will return true for both files and directory paths without trailing slashes.

[Arlo]

Good catch! Let's get this fixed.