Weekly scheduled smoke test: eslint-plugin-lit

Question

Weekly scheduled smoke test: eslint-plugin-lit

github-actions opened this issue 2 years ago · comments

github-actions commented 2 years ago

Detected 3 ESLint reports and/or crashes.
Scanned 5817 repositories.

Rules:

lit/value-after-constraints

Click to expand

Rule: lit/value-after-constraints

Message: Cannot read property 'value' of undefined Occurred while linting /github/workspace/ci/node_modules/eslint-remote-tester/.cache-eslint-remote-tester/qtqa/gerrit/polygerrit-ui/app/elements/admin/gr-create-group-dialog/gr-create-group-dialog.ts:51 Rule: "lit/value-after-constraints"
Path: qtqa/gerrit/polygerrit-ui/app/elements/admin/gr-create-group-dialog/gr-create-group-dialog.ts
Link

  49 |
  50 |   override render() {
> 51 |     return html`
  52 |       <div class="gr-form-styles">
  53 |         <div id="form">
  54 |           <section>

TypeError: Cannot read property 'value' of undefined
Occurred while linting /github/workspace/ci/node_modules/eslint-remote-tester/.cache-eslint-remote-tester/qtqa/gerrit/polygerrit-ui/app/elements/admin/gr-create-group-dialog/gr-create-group-dialog.ts:51
Rule: "lit/value-after-constraints"
    at Object.enterElement (/github/workspace/ci/node_modules/eslint-plugin-lit/lib/rules/value-after-constraints.js:47:54)
    at visit (/github/workspace/ci/node_modules/eslint-plugin-lit/lib/template-analyzer.js:257:29)
    at /github/workspace/ci/node_modules/eslint-plugin-lit/lib/template-analyzer.js:264:25
    at Array.forEach (<anonymous>)
    at visit (/github/workspace/ci/node_modules/eslint-plugin-lit/lib/template-analyzer.js:263:30)
    at /github/workspace/ci/node_modules/eslint-plugin-lit/lib/template-analyzer.js:264:25
    at Array.forEach (<anonymous>)
    at visit (/github/workspace/ci/node_modules/eslint-plugin-lit/lib/template-analyzer.js:263:30)
    at /github/workspace/ci/node_modules/eslint-plugin-lit/lib/template-analyzer.js:264:25
    at Array.forEach (<anonymous>)

Rule: lit/value-after-constraints

Message: Cannot read property 'value' of undefined Occurred while linting /github/workspace/ci/node_modules/eslint-remote-tester/.cache-eslint-remote-tester/qtqa/gerrit/polygerrit-ui/app/elements/admin/gr-repo-detail-list/gr-repo-detail-list.ts:236 Rule: "lit/value-after-constraints"
Path: qtqa/gerrit/polygerrit-ui/app/elements/admin/gr-repo-detail-list/gr-repo-detail-list.ts
Link

  234 |
  235 |   private renderItemList(item: BranchInfo | TagInfo, index: number) {
> 236 |     return html`
  237 |       <tr class="table">
  238 |         <td class="${this.detailType} name">
  239 |           <a href=${ifDefined(this.computeFirstWebLink(item))}>

TypeError: Cannot read property 'value' of undefined
Occurred while linting /github/workspace/ci/node_modules/eslint-remote-tester/.cache-eslint-remote-tester/qtqa/gerrit/polygerrit-ui/app/elements/admin/gr-repo-detail-list/gr-repo-detail-list.ts:236
Rule: "lit/value-after-constraints"
    at Object.enterElement (/github/workspace/ci/node_modules/eslint-plugin-lit/lib/rules/value-after-constraints.js:47:54)
    at visit (/github/workspace/ci/node_modules/eslint-plugin-lit/lib/template-analyzer.js:257:29)
    at /github/workspace/ci/node_modules/eslint-plugin-lit/lib/template-analyzer.js:264:25
    at Array.forEach (<anonymous>)
    at visit (/github/workspace/ci/node_modules/eslint-plugin-lit/lib/template-analyzer.js:263:30)
    at /github/workspace/ci/node_modules/eslint-plugin-lit/lib/template-analyzer.js:264:25
    at Array.forEach (<anonymous>)
    at visit (/github/workspace/ci/node_modules/eslint-plugin-lit/lib/template-analyzer.js:263:30)
    at /github/workspace/ci/node_modules/eslint-plugin-lit/lib/template-analyzer.js:264:25
    at Array.forEach (<anonymous>)

Rule: lit/value-after-constraints

Message: Cannot read property 'value' of undefined Occurred while linting /github/workspace/ci/node_modules/eslint-remote-tester/.cache-eslint-remote-tester/adobe/spectrum-web-components/packages/overlay/test/overlay.test.ts:345 Rule: "lit/value-after-constraints"
Path: adobe/spectrum-web-components/packages/overlay/test/overlay.test.ts
Link

  343 |
  344 |     it('closes an inline overlay when tabbing past the content', async () => {
> 345 |         const el = await fixture<HTMLDivElement>(html`
  346 |             <div>
  347 |                 <sp-button class="trigger">Trigger</sp-button>
  348 |                 <div class="content">

TypeError: Cannot read property 'value' of undefined
Occurred while linting /github/workspace/ci/node_modules/eslint-remote-tester/.cache-eslint-remote-tester/adobe/spectrum-web-components/packages/overlay/test/overlay.test.ts:345
Rule: "lit/value-after-constraints"
    at Object.enterElement (/github/workspace/ci/node_modules/eslint-plugin-lit/lib/rules/value-after-constraints.js:47:54)
    at visit (/github/workspace/ci/node_modules/eslint-plugin-lit/lib/template-analyzer.js:257:29)
    at /github/workspace/ci/node_modules/eslint-plugin-lit/lib/template-analyzer.js:264:25
    at Array.forEach (<anonymous>)
    at visit (/github/workspace/ci/node_modules/eslint-plugin-lit/lib/template-analyzer.js:263:30)
    at /github/workspace/ci/node_modules/eslint-plugin-lit/lib/template-analyzer.js:264:25
    at Array.forEach (<anonymous>)
    at visit (/github/workspace/ci/node_modules/eslint-plugin-lit/lib/template-analyzer.js:263:30)
    at /github/workspace/ci/node_modules/eslint-plugin-lit/lib/template-analyzer.js:264:25
    at Array.forEach (<anonymous>)

Ari Perkkiö · Answer 1 · Thu Dec 08 2022 21:36:53 GMT+0800 (China Standard Time)

First crash of eslint-plugin-lit 😮

cc @43081j if you are interested, likely related to 43081j/eslint-plugin-lit#145.

James Garbutt · Answer 2 · Thu Dec 08 2022 23:00:57 GMT+0800 (China Standard Time)

well that's a fun one isn't it :D

looks like somehow the attribute locations are nullish in your run. im not sure how that's possible 🤔

we can pretty easily account for that (which i may do anyway to be safe), but you shouldn't usually be able to end up in this situation... since source locations are generally always enabled. curious how it managed to do that

github-actions · Answer 3 · Thu Dec 15 2022 20:04:24 GMT+0800 (China Standard Time)

Detected 9 ESLint reports and/or crashes.
Scanned 6223 repositories.

Rules:

lit/value-after-constraints

Click to expand

Rule: lit/value-after-constraints

Message: Cannot read property 'value' of undefined Occurred while linting /github/workspace/ci/node_modules/eslint-remote-tester/.cache-eslint-remote-tester/js-works/js-cockpit/src/main/components/side-menu2/side-menu2.ts:49 Rule: "lit/value-after-constraints"
Path: js-works/js-cockpit/src/main/components/side-menu2/side-menu2.ts
Link

  47 |     }, 4000);
  48 |
> 49 |     return html`
  50 |       <div>
  51 |         <style>
  52 |           .tree {

TypeError: Cannot read property 'value' of undefined
Occurred while linting /github/workspace/ci/node_modules/eslint-remote-tester/.cache-eslint-remote-tester/js-works/js-cockpit/src/main/components/side-menu2/side-menu2.ts:49
Rule: "lit/value-after-constraints"
    at Object.enterElement (/github/workspace/ci/node_modules/eslint-plugin-lit/lib/rules/value-after-constraints.js:47:54)
    at visit (/github/workspace/ci/node_modules/eslint-plugin-lit/lib/template-analyzer.js:257:29)
    at /github/workspace/ci/node_modules/eslint-plugin-lit/lib/template-analyzer.js:264:25
    at Array.forEach (<anonymous>)
    at visit (/github/workspace/ci/node_modules/eslint-plugin-lit/lib/template-analyzer.js:263:30)
    at /github/workspace/ci/node_modules/eslint-plugin-lit/lib/template-analyzer.js:264:25
    at Array.forEach (<anonymous>)
    at visit (/github/workspace/ci/node_modules/eslint-plugin-lit/lib/template-analyzer.js:263:30)
    at /github/workspace/ci/node_modules/eslint-plugin-lit/lib/template-analyzer.js:264:25
    at Array.forEach (<anonymous>)

Rule: lit/value-after-constraints

Message: Cannot read property 'value' of undefined Occurred while linting /github/workspace/ci/node_modules/eslint-remote-tester/.cache-eslint-remote-tester/vaadin/web-components/packages/grid-pro/test/lit-renderer-directives.test.js:69 Rule: "lit/value-after-constraints"
Path: vaadin/web-components/packages/grid-pro/test/lit-renderer-directives.test.js
Link

  67 |
  68 |       beforeEach(async () => {
> 69 |         rendererSpy = sinon.spy(() => html`<input />`);
  70 |         render(
  71 |           html`<vaadin-grid-pro .items="${items}">
  72 |             <vaadin-grid-pro-edit-column

TypeError: Cannot read property 'value' of undefined
Occurred while linting /github/workspace/ci/node_modules/eslint-remote-tester/.cache-eslint-remote-tester/vaadin/web-components/packages/grid-pro/test/lit-renderer-directives.test.js:69
Rule: "lit/value-after-constraints"
    at Object.enterElement (/github/workspace/ci/node_modules/eslint-plugin-lit/lib/rules/value-after-constraints.js:47:54)
    at visit (/github/workspace/ci/node_modules/eslint-plugin-lit/lib/template-analyzer.js:257:29)
    at /github/workspace/ci/node_modules/eslint-plugin-lit/lib/template-analyzer.js:264:25
    at Array.forEach (<anonymous>)
    at visit (/github/workspace/ci/node_modules/eslint-plugin-lit/lib/template-analyzer.js:263:30)
    at TemplateAnalyzer.traverse (/github/workspace/ci/node_modules/eslint-plugin-lit/lib/template-analyzer.js:272:9)
    at TaggedTemplateExpression (/github/workspace/ci/node_modules/eslint-plugin-lit/lib/rules/value-after-constraints.js:40:30)
    at ruleErrorHandler (/github/workspace/ci/node_modules/eslint/lib/linter/linter.js:1115:28)
    at /github/workspace/ci/node_modules/eslint/lib/linter/safe-emitter.js:45:58
    at Array.forEach (<anonymous>)

Rule: lit/value-after-constraints

Message: Cannot read property 'value' of undefined Occurred while linting /github/workspace/ci/node_modules/eslint-remote-tester/.cache-eslint-remote-tester/vaadin/web-components/packages/grid-pro/test/lit.test.js:30 Rule: "lit/value-after-constraints"
Path: vaadin/web-components/packages/grid-pro/test/lit.test.js
Link

  28 |         };
  29 |         column.editModeRenderer = (root) => {
> 30 |           render(html`<input /> Edit Item`, root);
  31 |         };
  32 |
  33 |         flushGrid(grid);

TypeError: Cannot read property 'value' of undefined
Occurred while linting /github/workspace/ci/node_modules/eslint-remote-tester/.cache-eslint-remote-tester/vaadin/web-components/packages/grid-pro/test/lit.test.js:30
Rule: "lit/value-after-constraints"
    at Object.enterElement (/github/workspace/ci/node_modules/eslint-plugin-lit/lib/rules/value-after-constraints.js:47:54)
    at visit (/github/workspace/ci/node_modules/eslint-plugin-lit/lib/template-analyzer.js:257:29)
    at /github/workspace/ci/node_modules/eslint-plugin-lit/lib/template-analyzer.js:264:25
    at Array.forEach (<anonymous>)
    at visit (/github/workspace/ci/node_modules/eslint-plugin-lit/lib/template-analyzer.js:263:30)
    at TemplateAnalyzer.traverse (/github/workspace/ci/node_modules/eslint-plugin-lit/lib/template-analyzer.js:272:9)
    at TaggedTemplateExpression (/github/workspace/ci/node_modules/eslint-plugin-lit/lib/rules/value-after-constraints.js:40:30)
    at ruleErrorHandler (/github/workspace/ci/node_modules/eslint/lib/linter/linter.js:1115:28)
    at /github/workspace/ci/node_modules/eslint/lib/linter/safe-emitter.js:45:58
    at Array.forEach (<anonymous>)

Rule: lit/value-after-constraints

Message: Cannot read property 'value' of undefined Occurred while linting /github/workspace/ci/node_modules/eslint-remote-tester/.cache-eslint-remote-tester/anypoint-web-components/awc/test/lists/anypoint-item.test.ts:21 Rule: "lit/value-after-constraints"
Path: anypoint-web-components/awc/test/lists/anypoint-item.test.ts
Link

  19 |
  20 |   async function itemWithInputFixture(): Promise<HTMLDivElement> {
> 21 |     return fixture(html`<div role="list">
  22 |       <anypoint-item><input></anypoint-item>
  23 |     </div>`);
  24 |   }

TypeError: Cannot read property 'value' of undefined
Occurred while linting /github/workspace/ci/node_modules/eslint-remote-tester/.cache-eslint-remote-tester/anypoint-web-components/awc/test/lists/anypoint-item.test.ts:21
Rule: "lit/value-after-constraints"
    at Object.enterElement (/github/workspace/ci/node_modules/eslint-plugin-lit/lib/rules/value-after-constraints.js:47:54)
    at visit (/github/workspace/ci/node_modules/eslint-plugin-lit/lib/template-analyzer.js:257:29)
    at /github/workspace/ci/node_modules/eslint-plugin-lit/lib/template-analyzer.js:264:25
    at Array.forEach (<anonymous>)
    at visit (/github/workspace/ci/node_modules/eslint-plugin-lit/lib/template-analyzer.js:263:30)
    at /github/workspace/ci/node_modules/eslint-plugin-lit/lib/template-analyzer.js:264:25
    at Array.forEach (<anonymous>)
    at visit (/github/workspace/ci/node_modules/eslint-plugin-lit/lib/template-analyzer.js:263:30)
    at /github/workspace/ci/node_modules/eslint-plugin-lit/lib/template-analyzer.js:264:25
    at Array.forEach (<anonymous>)

Rule: lit/value-after-constraints

Message: Cannot read property 'value' of undefined Occurred while linting /github/workspace/ci/node_modules/eslint-remote-tester/.cache-eslint-remote-tester/anypoint-web-components/awc/test/overlay/OverlayElement.test.ts:87 Rule: "lit/value-after-constraints"
Path: anypoint-web-components/awc/test/overlay/OverlayElement.test.ts
Link

  85 |
  86 |   async function backdropFixture(): Promise<TestOverlay> {
> 87 |     return (fixture(html`<test-overlay withBackdrop>
  88 |       Overlay with backdrop
  89 |       <input disabled>
  90 |       <input>

TypeError: Cannot read property 'value' of undefined
Occurred while linting /github/workspace/ci/node_modules/eslint-remote-tester/.cache-eslint-remote-tester/anypoint-web-components/awc/test/overlay/OverlayElement.test.ts:87
Rule: "lit/value-after-constraints"
    at Object.enterElement (/github/workspace/ci/node_modules/eslint-plugin-lit/lib/rules/value-after-constraints.js:47:54)
    at visit (/github/workspace/ci/node_modules/eslint-plugin-lit/lib/template-analyzer.js:257:29)
    at /github/workspace/ci/node_modules/eslint-plugin-lit/lib/template-analyzer.js:264:25
    at Array.forEach (<anonymous>)
    at visit (/github/workspace/ci/node_modules/eslint-plugin-lit/lib/template-analyzer.js:263:30)
    at /github/workspace/ci/node_modules/eslint-plugin-lit/lib/template-analyzer.js:264:25
    at Array.forEach (<anonymous>)
    at visit (/github/workspace/ci/node_modules/eslint-plugin-lit/lib/template-analyzer.js:263:30)
    at TemplateAnalyzer.traverse (/github/workspace/ci/node_modules/eslint-plugin-lit/lib/template-analyzer.js:272:9)
    at TaggedTemplateExpression (/github/workspace/ci/node_modules/eslint-plugin-lit/lib/rules/value-after-constraints.js:40:30)

Rule: lit/value-after-constraints

Message: Cannot read property 'value' of undefined Occurred while linting /github/workspace/ci/node_modules/eslint-remote-tester/.cache-eslint-remote-tester/cice-classroom/cice-playground/packages/lit-element/todo/src/app-input.ts:14 Rule: "lit/value-after-constraints"
Path: cice-classroom/cice-playground/packages/lit-element/todo/src/app-input.ts
Link

  12 |
  13 |   render() {
> 14 |     return html`<label>${this.label}<input /></label>`
  15 |   }
  16 | }
  17 |

TypeError: Cannot read property 'value' of undefined
Occurred while linting /github/workspace/ci/node_modules/eslint-remote-tester/.cache-eslint-remote-tester/cice-classroom/cice-playground/packages/lit-element/todo/src/app-input.ts:14
Rule: "lit/value-after-constraints"
    at Object.enterElement (/github/workspace/ci/node_modules/eslint-plugin-lit/lib/rules/value-after-constraints.js:47:54)
    at visit (/github/workspace/ci/node_modules/eslint-plugin-lit/lib/template-analyzer.js:257:29)
    at /github/workspace/ci/node_modules/eslint-plugin-lit/lib/template-analyzer.js:264:25
    at Array.forEach (<anonymous>)
    at visit (/github/workspace/ci/node_modules/eslint-plugin-lit/lib/template-analyzer.js:263:30)
    at /github/workspace/ci/node_modules/eslint-plugin-lit/lib/template-analyzer.js:264:25
    at Array.forEach (<anonymous>)
    at visit (/github/workspace/ci/node_modules/eslint-plugin-lit/lib/template-analyzer.js:263:30)
    at TemplateAnalyzer.traverse (/github/workspace/ci/node_modules/eslint-plugin-lit/lib/template-analyzer.js:272:9)
    at TaggedTemplateExpression (/github/workspace/ci/node_modules/eslint-plugin-lit/lib/rules/value-after-constraints.js:40:30)

Rule: lit/value-after-constraints

Message: Cannot read property 'value' of undefined Occurred while linting /github/workspace/ci/node_modules/eslint-remote-tester/.cache-eslint-remote-tester/shoelace-style/shoelace/src/components/dialog/dialog.test.ts:121 Rule: "lit/value-after-constraints"
Path: shoelace-style/shoelace/src/components/dialog/dialog.test.ts
Link

  119 |
  120 |   it('should allow initial focus to be set', async () => {
> 121 |     const el = await fixture<SlDialog>(html` <sl-dialog><input /></sl-dialog> `);
  122 |     const input = el.querySelector('input')!;
  123 |     const initialFocusHandler = sinon.spy((event: Event) => {
  124 |       event.preventDefault();

TypeError: Cannot read property 'value' of undefined
Occurred while linting /github/workspace/ci/node_modules/eslint-remote-tester/.cache-eslint-remote-tester/shoelace-style/shoelace/src/components/dialog/dialog.test.ts:121
Rule: "lit/value-after-constraints"
    at Object.enterElement (/github/workspace/ci/node_modules/eslint-plugin-lit/lib/rules/value-after-constraints.js:47:54)
    at visit (/github/workspace/ci/node_modules/eslint-plugin-lit/lib/template-analyzer.js:257:29)
    at /github/workspace/ci/node_modules/eslint-plugin-lit/lib/template-analyzer.js:264:25
    at Array.forEach (<anonymous>)
    at visit (/github/workspace/ci/node_modules/eslint-plugin-lit/lib/template-analyzer.js:263:30)
    at /github/workspace/ci/node_modules/eslint-plugin-lit/lib/template-analyzer.js:264:25
    at Array.forEach (<anonymous>)
    at visit (/github/workspace/ci/node_modules/eslint-plugin-lit/lib/template-analyzer.js:263:30)
    at TemplateAnalyzer.traverse (/github/workspace/ci/node_modules/eslint-plugin-lit/lib/template-analyzer.js:272:9)
    at TaggedTemplateExpression (/github/workspace/ci/node_modules/eslint-plugin-lit/lib/rules/value-after-constraints.js:40:30)

Rule: lit/value-after-constraints

Message: Cannot read property 'value' of undefined Occurred while linting /github/workspace/ci/node_modules/eslint-remote-tester/.cache-eslint-remote-tester/shoelace-style/shoelace/src/components/drawer/drawer.test.ts:121 Rule: "lit/value-after-constraints"
Path: shoelace-style/shoelace/src/components/drawer/drawer.test.ts
Link

  119 |
  120 |   it('should allow initial focus to be set', async () => {
> 121 |     const el = await fixture<SlDrawer>(html` <sl-drawer><input /></sl-drawer> `);
  122 |     const input = el.querySelector<HTMLInputElement>('input')!;
  123 |     const initialFocusHandler = sinon.spy((event: InputEvent) => {
  124 |       event.preventDefault();

TypeError: Cannot read property 'value' of undefined
Occurred while linting /github/workspace/ci/node_modules/eslint-remote-tester/.cache-eslint-remote-tester/shoelace-style/shoelace/src/components/drawer/drawer.test.ts:121
Rule: "lit/value-after-constraints"
    at Object.enterElement (/github/workspace/ci/node_modules/eslint-plugin-lit/lib/rules/value-after-constraints.js:47:54)
    at visit (/github/workspace/ci/node_modules/eslint-plugin-lit/lib/template-analyzer.js:257:29)
    at /github/workspace/ci/node_modules/eslint-plugin-lit/lib/template-analyzer.js:264:25
    at Array.forEach (<anonymous>)
    at visit (/github/workspace/ci/node_modules/eslint-plugin-lit/lib/template-analyzer.js:263:30)
    at /github/workspace/ci/node_modules/eslint-plugin-lit/lib/template-analyzer.js:264:25
    at Array.forEach (<anonymous>)
    at visit (/github/workspace/ci/node_modules/eslint-plugin-lit/lib/template-analyzer.js:263:30)
    at TemplateAnalyzer.traverse (/github/workspace/ci/node_modules/eslint-plugin-lit/lib/template-analyzer.js:272:9)
    at TaggedTemplateExpression (/github/workspace/ci/node_modules/eslint-plugin-lit/lib/rules/value-after-constraints.js:40:30)

Rule: lit/value-after-constraints

Message: Cannot read property 'value' of undefined Occurred while linting /github/workspace/ci/node_modules/eslint-remote-tester/.cache-eslint-remote-tester/alpinejs/alpine/tests/cypress/integration/plugins/morph.spec.js:138 Rule: "lit/value-after-constraints"
Path: alpinejs/alpine/tests/cypress/integration/plugins/morph.spec.js
Link

  136 |
  137 | test('can morph',
> 138 |     [html`
  139 |         <ul>
  140 |             <li>foo<input></li>
  141 |         </ul>

TypeError: Cannot read property 'value' of undefined
Occurred while linting /github/workspace/ci/node_modules/eslint-remote-tester/.cache-eslint-remote-tester/alpinejs/alpine/tests/cypress/integration/plugins/morph.spec.js:138
Rule: "lit/value-after-constraints"
    at Object.enterElement (/github/workspace/ci/node_modules/eslint-plugin-lit/lib/rules/value-after-constraints.js:47:54)
    at visit (/github/workspace/ci/node_modules/eslint-plugin-lit/lib/template-analyzer.js:257:29)
    at /github/workspace/ci/node_modules/eslint-plugin-lit/lib/template-analyzer.js:264:25
    at Array.forEach (<anonymous>)
    at visit (/github/workspace/ci/node_modules/eslint-plugin-lit/lib/template-analyzer.js:263:30)
    at /github/workspace/ci/node_modules/eslint-plugin-lit/lib/template-analyzer.js:264:25
    at Array.forEach (<anonymous>)
    at visit (/github/workspace/ci/node_modules/eslint-plugin-lit/lib/template-analyzer.js:263:30)
    at /github/workspace/ci/node_modules/eslint-plugin-lit/lib/template-analyzer.js:264:25
    at Array.forEach (<anonymous>)