More feedback types for impact and notification

Question

More feedback types for impact and notification

jhen0409 opened this issue 7 years ago · comments

Jhen-Jie Hong commented 7 years ago

Feedback guideline from Apple

Currently this module isn't supported all feedback types for impact and notification

impact - UIImpactFeedbackStyle
notification - UINotificationFeedbackType

Let me know if PR welcome. :)

Charles Vinette · Answer 1 · Thu Oct 12 2017 23:29:45 GMT+0800 (China Standard Time)

Hey @jhen0409 . Wow, I am so sorry I didn't get back to you before, I totally missed the issue. PR's are more than welcome! Cute dog by the way :)

Spencer Shulem · Answer 2 · Fri Dec 22 2017 00:56:23 GMT+0800 (China Standard Time)

Second this. Thank you for this, definitely helpful!

Here is a full list of feedbacks:

Notifications:

Success
Warning
Failure

Impact:

Light
Medium
Heavy

Selection:

Selection

https://developer.apple.com/ios/human-interface-guidelines/user-interaction/feedback/

Look likes currently supported is:

Warning
Possibly light, or medium, or heavy
Selection

Doney den Ouden · Answer 3 · Thu Feb 22 2018 21:57:58 GMT+0800 (China Standard Time)

Any movement on this? Would be very much appreciated 🙏🏼

Charles Vinette · Answer 4 · Fri Feb 23 2018 01:47:16 GMT+0800 (China Standard Time)

Hey @Spshulem and @Dexwell, thanks for your feedback. I will take some next week to add those. I'll get back to you then. Have a good weekend!

Doney den Ouden · Answer 5 · Sun Apr 15 2018 01:34:30 GMT+0800 (China Standard Time)

Don't mean to pressure you, but any ETA on this? 💝

Charles Vinette · Answer 6 · Tue Apr 17 2018 01:06:43 GMT+0800 (China Standard Time)

Hey no pressure at all, I am so sorry for the wait @Dexwell we are busy these past couple of weeks haha. I'd really like to take some time 'soonish' to add those. I will ping back when it is, hopefully by the end of the month :)

Doney den Ouden · Answer 7 · Fri Jun 22 2018 17:27:00 GMT+0800 (China Standard Time)

Which month? 😜

Charles Vinette · Answer 8 · Tue Jun 26 2018 23:36:09 GMT+0800 (China Standard Time)

@Dexwell Haha hey Doney, sorry about that, I was planning April 😬 but things are crazy at App & Flow so I had to postpone. It's still on my to do list. PR's welcomed !!

Bryan Clark · Answer 9 · Tue Jul 10 2018 02:55:38 GMT+0800 (China Standard Time)

Working on a PR!

Doney den Ouden · Answer 10 · Tue Jul 10 2018 04:11:19 GMT+0800 (China Standard Time)

@bryanjclark Music to my ears! 💜