dynamic mode based on brightness doesn't work latest macbook
idoo opened this issue · comments
Looks like something broken on latest MacBook with touch bar (maybe it's because the controller of brightness has been moved to T2 chip)
Do you have any ideas how to solve it?
If your Mac has an ambient light sensor, choose Apple menu > System Preferences, click Displays, then click Display, then select “Automatically adjust brightness.” Could you please try this first?
it set by default
I actually experienced this myself today. Can you try to first disable then enable Auto Adjust within Dynamic Dark Mode and see if that works?
nope :( still the same result :(
btw, how you detect the brightness?
https://github.com/ApolloZhu/Dynamic-Dark-Mode/blob/master/Dynamic/Utilities/Brightness/NSScreen%20%2B%20Brightness.swift handles that.
And there is a bug that when there are more than one displays, the program can’t determine the current brightness value.
so, it is based on display brightness, not light sensor, right?
it makes sense, because as I understand there is no way to get value from the light sensor on macs with T1 and T2 chips, because it used private API that doesn't works anymore (it still works well on mac without touchbar btw)
Okay....
I’ll try to find a Mac that I can test on and see if there’s a way to solve this problem
let me know if I can help you somehow, I have a mac with T2 chip
https://stackoverflow.com/a/18614019
there was a way to read such data from an Ambilight sensor (you still can use it for old MacBooks), but there are not AppleLMUController anymore ¯_(ツ)_/¯
So, I'll appreciate if you can find some way to read it
I don't think https://github.com/ApolloZhu/Dynamic-Dark-Mode/releases/tag/1.1.1 helps much, but it did solve the problem for me myself. Can you try this new version and see what happens?
@idoo I just tested the 1.1.1 release on my friend's new MacBook Pro 2018 with touch bar and it works perfectly. You should try it out and see if it works or not. Or you can describe your situation in more details so I may find out what other things could have caused the problem.
sorry, didn't respond, yes, it works perfectly now! thanks!