Snapper + Debian 12 broken after last couple commits
david-cortes opened this issue · comments
If installing grub-btrfs from the current master branch, snapper snapshots will not be found in debian.
I did some testing with previous versions, and can tell for now that:
- Commit ec5ff8b makes it fail due to some syntax error compared to the previous commit. Not sure if it's related.
- Under commit 879bec3 (throughout the current commit at the time of writing, c7d4bbb) it then doesn't fail due to some syntax error when findind snapshots, but it reports no snapshots being found despite there being snapper snapshots.
- Under commit 1556c34 (the one that commes immediately before the commit listed in the first bullet point), everything seems to work correctly - snapshots are found, a boot menu is generated, and it's possible to boot into those snapshots.
Hi, thanks for bisecting this. The syntax error from your first bullet point isn't related, this was just my git commit hooks messing up the config file.
Have you tried this? #256 (comment)
Comparing the last working commit for and the current last commit I can only imagine this line to be the problem:
https://github.com/Antynea/grub-btrfs/compare/1556c345dac23c1f13ca6470c7ff68a22d56971c..c7d4bbbe4576d5777e750759676710a303bfe87#diff-9b6d1a434bd2a223bf71bbbb1393b35e131311e2a8369779c6be2a116626630fL298
Do you mind installing the last commit, changing the line back to what is was on the last working commit and check if it works? The weird thing is, I have no trouble at all, yet we are all should be running the same bash.
sorry for autoclosing this so fast. Please check if latest commit fixes this. I think it should.
Still freaks me out that different distros bash versions differ so much.
Thanks. Tried again - it works with the latest commit (c6550d0), and doesn't find any snapshots if I enquote that variable snap on https://github.com/Antynea/grub-btrfs/blob/master/41_snapshots-btrfs:L300 as it was before this last commit.