3.1.0 tag and update repo

Question

3.1.0 tag and update repo

leela52452 opened this issue 5 years ago · comments

@AntonioRedondo
google play 3.1.0
can you please update repo for 3.1.0 and create tag, version code & name.

Antonio Redondo · Answer 1 · Sun Oct 06 2019 17:00:23 GMT+0800 (China Standard Time)

Hey @leela52452,
I don't have much time at the moment to do it. But if you open a pull request with working changes I'll merge them to master.

Nowshad Hasan · Answer 2 · Tue Jan 14 2020 13:21:28 GMT+0800 (China Standard Time)

Hey @AntonioRedondo, will you mind if I work on to update the repo with build tools 'com.android.tools.build:gradle:3.5.3', target sdk to 29, migrate to androidx, java version update to 1.8? Actually I'm very new to open source and trying to find some easy stuffs to do. Thanks.

Antonio Redondo · Answer 3 · Tue Jan 14 2020 14:28:21 GMT+0800 (China Standard Time)

Hello @nowshad-hasan,
That would be great! If you open a pull request with the changes I'll definitively merge it.

Nowshad Hasan · Answer 4 · Wed Jan 15 2020 23:30:24 GMT+0800 (China Standard Time)

Hi @AntonioRedondo, I've made some changes regarding these issues:

Create a notification channel for devices>=Oreo
Remove version related useless code from manifest and gradle files
Migrate to androidx.
Update gradle distribution to 5.4.1
Update gradle build to 3.5.3
Make TargetSdkVersion to 29(android 10)
Make source compatibility to JAVA 1.8

And do you want me to update version code from 9 to 10 and version name to 3.1.0 to 3.2.0 or something other? Just confirm me, so that I can make a PR with all of these changes.

Antonio Redondo · Answer 5 · Thu Jan 16 2020 04:38:09 GMT+0800 (China Standard Time)

Since this seems version bump ups and doesn't have new user features I think it would be better to set the version as 3.1.1. However I'm cannot be 100% sure until I see the pull request.

Antonio Redondo · Answer 6 · Thu Jan 30 2020 21:09:54 GMT+0800 (China Standard Time)

Closing this issue as it has been fixed on #12