Unable to use new UseHex property as it is in an internal structure
a-teece opened this issue · comments
The new UseHex property is a great idea, but it can't easily be used as the Structure is internal.
I assume the unit tests are passing because they have access to internal classes/structs/etc.
We're working around using reflection to set it for now, but a fix would be nice.
It would still be nice to disable all colour normalisation given the popularity of AngleSharp and the problems RGBA causes for Outlook - a pretty common use-case in the wild.
We're hoping that UseHex is a good-enough fix for now
It would still be nice to disable all colour normalisation given the popularity of AngleSharp and the problems RGBA causes for Outlook - a pretty common use-case in the wild.
Yeah I think a better model is soon incoming, where you can actually determine the output of color values in the formatter already (right now the CSS formatter only deals with high level things such as rules or declarations, not with (primitive) values).
In the meantime we should make the struct public - do you mind making a PR for this one? Then we can release the latest version. Would be superb (all that's needed is IIRC to make it public - everything else should be prepared already in devel).
Thanks
Sorry for not responding, I didn't just ignore the request, Shesh is a member of our team at Enate who was closer to the original CSS problem so I asked him to help get this over the line.
Great - thanks for the heads up!