[BUG]: Payment date error: 'Invalid Date' when editing another day than creating

Question

[BUG]: Payment date error: 'Invalid Date' when editing another day than creating

Tech6767 opened this issue 2 years ago · comments

Describe the bug
Small thing I just noticed:
When creating an invoice on day one and it is getting edited on day 2, if there was a payment date set to 10 days (probably others as well) it will show an error.

This happened, when I created an invoice at like 23:50 and edited it at 0:05 in the night. Suddenly the payment date was broken.

The creation date is the date of editing, which is fine (and correct), but I guess it is the source of the bug.

To Reproduce
Steps to reproduce the behavior:

Create an invoice
set payment date to 10 days
edit the invoice a day later
See error

Expected behavior
The date should be recalculated for the new creation date of the invoice.
example: First creation date: 4. June 22
payment date: 14. June 22
edited creation date: 5. June 22
payment date: 15. June 22
Screenshots

Desktop (please complete the following information):

OS: Pop!_OS
Version 22.04

Andrés Morelos · Answer 1 · Mon Jun 06 2022 02:03:42 GMT+0800 (China Standard Time)

@Tech6767 could you please share with me the invoncify version? I'm not able to reproduce it in the latest version.

Tech6767 · Answer 2 · Tue Jun 07 2022 01:17:01 GMT+0800 (China Standard Time)

I am using the Invoncify-1.17.1.AppImage from Github. @AndresMorelos

Andrés Morelos · Answer 3 · Tue Jun 07 2022 21:31:23 GMT+0800 (China Standard Time)

@Tech6767, still not getting this issue, either with that version of Invoncify or later, I didn't test on your specific OS, so let me verify If I can make a VM with that OS and test it.

Tech6767 · Answer 4 · Wed Jun 08 2022 03:11:58 GMT+0800 (China Standard Time)

@AndresMorelos I will try again. I opened another invoice and will edit it tomorrow. If it does not happen again, I will close the issue. Thanks for trying.

Andrés Morelos · Answer 5 · Fri Jun 10 2022 12:32:07 GMT+0800 (China Standard Time)

@Tech6767, did you reproduce the issue?

Tech6767 · Answer 6 · Sat Jun 11 2022 01:23:17 GMT+0800 (China Standard Time)

@AndresMorelos I forgot about it...tried it now and yes, it still occurs:

Maybe it needs to be in german? I entered more text in the payment details field, that's how it changes the creation date and then it messes up the 10 days due date.

Tech6767 · Answer 7 · Sat Jun 11 2022 01:23:31 GMT+0800 (China Standard Time)

I can update the app and see if it still occurs?

Andrés Morelos · Answer 8 · Sat Jun 11 2022 02:07:20 GMT+0800 (China Standard Time)

@Tech6767 yes, you can update the app, there is not problem.

I will setup your OS on a VM in order to test it.

Andrés Morelos · Answer 9 · Mon Jun 13 2022 11:33:12 GMT+0800 (China Standard Time)

@Tech6767 I was able to reproduce the issue but without changing the Creation date, just selecting another due date term.

I'm working on this Right, the new versión of the app will be released soon with the fix. stay tunned.

Andrés Morelos · Answer 10 · Mon Jun 13 2022 12:11:36 GMT+0800 (China Standard Time)

@Tech6767 Issue fix at v1.9.1, If the issue persists for you please reopen the issue and attach a video with your steps, the only way that I was able to reproduce it was without updating the creation date.