[Feature Request]

Question

[Feature Request]

HBDrew opened this issue 9 months ago · comments

Is your feature request related to a problem? Please describe.
Not a problem, just an improvement for cleaning. It would be awesome to have a relay to switch the pump directions for cleaning. This would allow for backing the liquid out of the lines both before and after cleaning.

Describe the solution you'd like
An option to control a single relay to reverse all pumps for cleaning.

Alternative*
I have considered a separate physical switch to perform this and it may be the easiest solution, but certainly isn’t as fun! :-)

Andre Wohnsland · Answer 1 · Mon Oct 16 2023 03:22:40 GMT+0800 (China Standard Time)

Hey, this sounds for a good addition.
To understand the technical needed details: the inversion/switching of the pump direction is just the activation of the relay over an additional GPIO (let it call the inverter pin for now) for the duration of the inversion?

I can imagine one of two flows:

before cleaning, the inverter relay could be activated, then the pumps would activate a short period, the inversion stops and the regular cleaning begins and after that the inversion once again activates and the remaining fluid is flown in the opposite direction again.
There is a separate option called inverse cleaning (or similar) the user can click instead of cleaning, this would work like the cleaning but activated the inverter Relais before and deactivates after the process.

Currently leaning towards option 2 since one may want to go a cleaning or inverse step multiple times if needed.

HBDrew · Answer 2 · Mon Oct 16 2023 04:24:53 GMT+0800 (China Standard Time)

Yes, that’s how I envisioned it working. Just switches the the relays (it would technically require two relays, but still one channel)I like your idea on option 2, it gives more flexibility.Wiring would look something like this: AndrewOn Oct 15, 2023, at 12:22, Andre Wohnsland ***@***.***> wrote: Hey, this sounds for a good addition. To understand the technical needed details: the inversion/switching of the pump direction is just the activation of the Relais over an additional (let it call the inverter pin for now) for the duration of the inversion? I can imagine one of two flows: before cleaning, the inverter relais could be activated, then the pumps would activate a short period, the inversion stops and the regular cleaning begins and after that the inversion once again activates and the remaining fluid is flown in the opposite direction again. There is a separate option called inverse cleaning (or similar) the user can click instead of cleaning, this would work like the cleaning but activated the inverter Relais before and deactivates after the process. Currently leaning towards option 2 since one may want to go a cleaning or inverse step multiple times if needed. —Reply to this email directly, view it on GitHub, or unsubscribe.You are receiving this because you authored the thread.Message ID: ***@***.***>

Andre Wohnsland · Answer 3 · Tue Oct 17 2023 01:04:42 GMT+0800 (China Standard Time)

Hey @HBDrew, do you have any setup / software with which you could test the feature?
The current implementation will ask before starting the cleaning (if reversion option is activated) if to revert the cleaning. If prompted with yes, the cleaning will start reverted, otherwise it will start normally. Users not having this option enabled will not be prompted with this question. This was done to not clutter the UI with multiple clean buttons. In theory and code perspective it does work, but I can't validate it against physical hardware, since I have no bidirectional pumps nor a two current way setup. Anyway, I will release this feature with the next update, but you can already test it now if you switch to the "dev" branch after pulling the latest git status with git pull, if you want to check it out.

HBDrew · Answer 4 · Tue Oct 17 2023 01:18:39 GMT+0800 (China Standard Time)

Fantastic! I’m building my setup right now, but should be at a point where I can test it this weekend. I’ll get it breadboarded and give it a go and let you know how it works.Thanks! AndrewOn Oct 16, 2023, at 10:04, Andre Wohnsland ***@***.***> wrote: Hey @HBDrew, do you have any setup / software with which you could test the feature? The current implementation will ask before starting the cleaning (if reversion option is activated) if to revert the cleaning. If prompted with yes, the cleaning will start reverted, otherwise it will start normally. Users not having this option enabled will not be prompted with this question. This was done to not clutter the UI with multiple clean buttons. In theory and code perspective it does work, but I can't validate it against physical hardware, since I have no bidirectional pumps nor a two current way setup. Anyway, I will release this feature with the next update, but you can already test it now if you switch to the "dev" branch after pulling the latest git status with git pull, if you want to check it out. —Reply to this email directly, view it on GitHub, or unsubscribe.You are receiving this because you were mentioned.Message ID: ***@***.***>

Andre Wohnsland · Answer 5 · Mon Oct 23 2023 17:18:56 GMT+0800 (China Standard Time)

Hey, @HBDrew, were you able you test it? I would close this issue, unless you have any issues with the current status, but then you can always reopen the issue as well.

HBDrew · Answer 6 · Mon Oct 23 2023 21:57:24 GMT+0800 (China Standard Time)

Hey there.I was able to do a little testing and didn’t have any luck getting it to work. I may have been doing something wrong, but no matter what pin I select it doesn’t seem to work. The program doesn’t launch, I get an error about GPIO configuration, and I then have to go back into the config file and set inversion back to false. It could be that I missed something… AndrewOn Oct 23, 2023, at 02:19, Andre Wohnsland ***@***.***> wrote: Hey, @HBDrew, were you able you test it? I would close this issue, unless you have any issues with the current status, but then you can always reopen the issue as well. —Reply to this email directly, view it on GitHub, or unsubscribe.You are receiving this because you were mentioned.Message ID: ***@***.***>

Andre Wohnsland · Answer 7 · Tue Oct 24 2023 00:04:51 GMT+0800 (China Standard Time)

Can you send me the error (or a picture) and the config file with it? Did you set all config over the program (GUI) or did you temper in the config file? Doing over the GUI, usually you won't be able to enter bad values, when entering values via an editor in the config, I can only check them for reason at program start and they may be faulty.

HBDrew · Answer 8 · Tue Oct 24 2023 00:25:40 GMT+0800 (China Standard Time)

Yep. I’ll send you the error log. I actually tried both ways. I also tried assigning one of the existing output pins as well as a different one. I also have configured the relevant GPIO pins as output in the boot config file. AndrewOn Oct 23, 2023, at 09:05, Andre Wohnsland ***@***.***> wrote: Can you send me the error (or a picture) and the config file with it? Did you set all config over the program (GUI) or did you temper in the config file? Doing over the GUI, usually you won't be able to enter bad values, when entering values via an editor in the config, I can only check them for reason at program start and they may be faulty. —Reply to this email directly, view it on GitHub, or unsubscribe.You are receiving this because you were mentioned.Message ID: ***@***.***>

Andre Wohnsland · Answer 9 · Tue Oct 24 2023 00:31:50 GMT+0800 (China Standard Time)

Well, I think I found the Issue. Please update with the terminal (git pull) to the latest (1.27.1) version. This should then work properly (hopefully). If it was the error, I was able to recreate on one of my hardwares.

HBDrew · Answer 10 · Tue Oct 24 2023 00:32:42 GMT+0800 (China Standard Time)

Here you go.Set the inversion pin to 9 for this one… AndrewOn Oct 23, 2023, at 09:05, Andre Wohnsland ***@***.***> wrote: Can you send me the error (or a picture) and the config file with it? Did you set all config over the program (GUI) or did you temper in the config file? Doing over the GUI, usually you won't be able to enter bad values, when entering values via an editor in the config, I can only check them for reason at program start and they may be faulty. —Reply to this email directly, view it on GitHub, or unsubscribe.You are receiving this because you were mentioned.Message ID: ***@***.***>

Andre Wohnsland · Answer 11 · Tue Oct 24 2023 01:18:00 GMT+0800 (China Standard Time)

Well, I think I found the Issue. Please update with the terminal (git pull) to the latest (1.27.1) version. This should then work properly (hopefully). If it was the error, I was able to recreate on one of my hardwares.

@HBDrew Can you give me feedback if this works, when you tested it? :)

HBDrew · Answer 12 · Tue Oct 24 2023 01:26:50 GMT+0800 (China Standard Time)

Just tested it. Seems to work! At least it switches a relay connected to the GPIO pin. I have to wire up the pumps still, as my project is transitioning from prototype to full version. Looks good! I would consider it closed.I’ll send pics of my completed project once it’s fully up and running. AndrewOn Oct 23, 2023, at 10:18, Andre Wohnsland ***@***.***> wrote: Well, I think I found the Issue. Please update with the terminal (git pull) to the latest (1.27.1) version. This should then work properly (hopefully). If it was the error, I was able to recreate on one of my hardwares. @HBDrew Can you give me feedback if this works, when you tested it? :) —Reply to this email directly, view it on GitHub, or unsubscribe.You are receiving this because you were mentioned.Message ID: ***@***.***>