Anchor-Protocol / anchor-token-contracts

Smart contracts powering Anchor Protocol on Terra

Geek Repo:Geek Repo

Github PK Tool:Github PK Tool

Wrong constant usage in tests

pronvis opened this issue · comments

creator_env.block.height += DEFAULT_TIMELOCK_PERIOD;

It should be: creator_env.block.height += DEFAULT_VOTING_PERIOD;
but, because values are the same:

const DEFAULT_VOTING_PERIOD: u64 = 10000u64;
const DEFAULT_TIMELOCK_PERIOD: u64 = 10000u64;

test passed. I recommend to always use unique values in constants for tests.

commented

Thanks for bringing this up @pronvis! Fixed in the PR mentioned above :) Will close this issue when that merges

commented

#15 merged