[Bug Report] Application of Discontinued GitHub Action
kevinmatthes opened this issue · comments
In line 55-59 of release.yml, you call the Action actions-rs/toolchain which is discontinued; see actions-rs/toolchain#216. Rust is already installed on the runner, you can always call rustup update for a self-upgrade and add components manually.
Thanks for catching the bug @kevinmatthes
The release pipeline is still a work in progress since it hasn't run until now successfully. Actually I'm not happy with it until now, and I intend to make some other improvements there too.
I think then I can remove the whole 'Install Rust' part since it's already installed
I found another discontinued Action in the workflow; this is the minor bug I mentioned in kevinmatthes/aeruginous-rs#337. The release creation Action is a public archive, so there are not going to be any updates, anymore.
However, I think I found a working alternative: https://github.com/softprops/action-gh-release. I tested it for the release of Aeruginous v2.2.1 and it worked without any problems. I even found out how to customise the automatically generated release notes: https://docs.github.com/en/repositories/releasing-projects-on-github/automatically-generated-release-notes#configuring-automatically-generated-release-notes.
What do you think about this?
I think it's better to write it from scratch using the new action than trying to fix the current one.
I can take a look on your solution for inspirations and change the one here, or you can gladly implement it here too if you want to 😃
I'll give it a try, since I'm intending to make a minor release today
I made the adjustments on the release workflow, and pushed it by mistake directly on the master. This should be closed now, and it will get tested in the next release