self.signal_features[0] and self.signal_features[-1] are never be used
lbgitjp opened this issue · comments
in the class TradingEnv, self.signal_features[0] and self.signal_features[-1] are never be used.
- below code will skip self.signal_features[0]:
gym-anytrading/gym_anytrading/envs/trading_env.py
Lines 104 to 105 in 296bae4
I think it should be changed to:
def _get_observation(self):
return self.signal_features[(self._current_tick-self.window_size):self._current_tick]
-
below code will skip self.signal_features[-1]:
gym-anytrading/gym_anytrading/envs/trading_env.py
Lines 75 to 76 in 296bae4
I think it should be changed to:if self._current_tick == self._end_tick+ 1: self._done = True
thanks!