[BUG] from_ir_datasets seems to be missing from Qrels

Question

[BUG] from_ir_datasets seems to be missing from Qrels

cadurosar opened this issue 2 years ago · comments

Carlos Eduardo Rosar Kós Lassance commented 2 years ago

Describe the bug
Qrels.from_ir_datasets("msmarco-document/dev") does not seem to work, it seems to have been removed by a commit 10 days ago. (e0ca82c)

Elias Bassani · Answer 1 · Fri Jun 17 2022 00:30:29 GMT+0800 (China Standard Time)

Hi and thank you very much for pointing it out.
I must have used an old version of the code when I did the refactoring from the commit you mentioned, gotta check everything... :S

I restored "from_ir_datasets" in v0.2.4.

Thanks again!

Carlos Eduardo Rosar Kós Lassance · Answer 2 · Fri Jun 17 2022 00:31:30 GMT+0800 (China Standard Time)

Thanks a lot for this library, just came back after a while and this feature is pretty great, thanks for fixing it!

Elias Bassani · Answer 3 · Fri Jun 17 2022 00:37:07 GMT+0800 (China Standard Time)

Super glad you like it! :D
Please, give it a star if you haven't yet and spread the word!