paper.toJSON() does not work for id attributes

[Ryan M]

Draw any element and assign it an id:

var c = paper.circle(10,10,5);
c.node.id = "mycircle";

Run:

var json = paper.toJSON();
paper.clear();
paper.fromJSON(json);

The json object will be missing the id="mycircle" on the circle node.

[Elbert Alias]

toJSON omits quite a bit of data, it basically saves just enough to be able to redraw the shapes later. You can add id: node.id under the line that contains nodes.push. Since it's only a small change I'll add this in when I get the chance (or you can issue a pull request).

[Elbert Alias]

This has been fixed.

[Ryan M]

Thank you.

[Ryan M]

I think your fix saves Raphael's internal id for the node, as a style attribute:

<circle style="id='5'"></circle>

But I am trying to save this id:

<circle id="mycircle"></circle>

Which in Raphael is set like:

var c = paper.circle(10,10,5);
c.node.id = "mycircle";

[Ryan M]

I said it was saving to the style attribute: my mistake, it's saving to the id attribute. Trouble is, it's saving Raphael's internal id for the element instead of the value for the element's id attribute. Thus later when I restore using fromJSON() I see:

<circle id="5"></circle>

Instead of:

<circle id="mycircle"></circle>

(This assumes we add .id(json[i].id) below line 26 in fromJSON().)

[Elbert Alias]

Ah yes, keeping the actual HTML id attribute makes sense. I'll look into that.

[Ryan M]

Thanks!

[Elbert Alias]

Should be working now.