AliSoftware / OHHTTPStubs

Stub your network requests easily! Test your apps with fake network data and custom response time, response code and headers!

Geek Repo:Geek Repo

Github PK Tool:Github PK Tool

Incorrect example for onStubActivation on Usage Examples page

kirilstrax opened this issue · comments

New Issue Checklist

Environment

  • version of OHHTTPStubs: 8.0.0
  • integration method you are using:
    • Cocoapods
    • Carthage
    • submodule
    • other
  • version of the tool you use: not applicable

Issue Description

The example on Usage Examples page is shown as follows:

// Swift
OHHTTPStubs.onStubActivation() { request, stub in
  println("\(request.URL!) stubbed by \(stub.name).")
}

Problem 1: Signature of onStubActivation was changed a few versions ago. So it should be:

OHHTTPStubs.onStubActivation() { request, stub, response in

This problem applies to both, Swift and Objective C examples

Problem 2: replace println with print in Swift, as there's no println function in swift.

Problem 3: in Swift, NSURLRequest is bridged as URLRequest, and instead of request.URL!, it uses lower-cased request.url!

Bottom line: example in Swift should look something like this:

// Swift
OHHTTPStubs.onStubActivation() { request, stub, response in
  print("\(request.url!) stubbed by \(stub.name) of size \(response.dataSize).")
}
Complete output when you encounter the issue (if any)

This is documentation update issue, so not applicable.