Update SDR++ to support RSP-1B / RSPdxR2
chipperdfw opened this issue · comments
The new SDRplay RSP-1B is not supported in version 1.1.0. There appears to be some changes in the API for the RSP-1B.
Hopefully you can update to support in the near future.
I don't have one so can't test/validate anything. Will be a while before this can be added.
I am happy to help you test (if you want). The operation should be similar to the RSP1A.
At a minimum, can you add provisions for RSP1B to the SDRPlusPlus/source_modules/sdrplay_source/src/main.cpp:
case SDRPLAY_RSP1B_ID:
name = "RSP1B (";
name += devArr[i].SerNo;
name += ')';
break;
and duplicate the cases where openDev.hwVer == SDRPLAY_RSP1A_ID for RSP1B?
The device seems to be working, but is showing in the "source" as "Device currently unsupported" and the bandwidth and IF selections are unavailable. I think these changes would resolve that.
This is my last working version with a RSP1a
RSP1B with SDRplay API v3.14 on Windows 10.
Would you like me to test with RSP-1A and API v3.14? I think I used v3.12 previously.
'appreciate you don't take PRs, link below essentially clones the RSP1A functionality as I don't believe there's much difference. I'm willing to be proven wrong.
https://github.com/Dustify/SDRPlusPlus/blob/rsp1b/source_modules/sdrplay_source/src/main.cpp
It appears to be behaving itself for me with limited testing.
Tried @Dustify's suggestion, but he didn't have OPT_BUILD_SDRPLAY_SOURCE set to ON in CMakeLists.txt. I did that, but it doesn't recognize my RSP1B. When building the MacOS bundle it says at one point
Installing ./build/source_modules/sdrplay_source/sdrplay_source.dylib ==NOT== Installing libsdrplay_api.so.3.14
but it seems to also does the same if I go to version 3.12 with the RSP1B stuff removed. I don't have an RTL or something on me to see if my build is even working correctly, but I can go try tomorrow.
@JordanSavoie rather than change the source, you can specify options when you run cmake, e.g.
cmake .. -DOPT_BUILD_SDRPLAY_SOURCE=true
Can you check under "Module Manager" to see if you have an instance of "sdrplay_source". If not, does it appear in the list at the bottom so you can add it?
It doesn't show up in my module manager nor the list, neither in my build or in the nightly release.
@JordanSavoie not sure how much more help I can provide as don't have a mac to attempt the build on. Have you installed the SDRPlay API?
Hopefully the maintainer will be able to help.
@Dustify Yeah I have it installed. I'm on M1 and don't really know what I'm doing anyway, so it's not too surprising that I wasn't able to get it working :p. Alexandre seems to be doing some work with an ARM build, so maybe he'll find something wrong
@Dustify I did exactly the same modifications, and have it running on MacOS 14.2.1 (Intel)
i.e. see master...ebirn:SDRPlusPlus:add_sdrplay_rsp1b
I also made similar changes (i.e. treat rsp1b as if it behaves exactly the same as rsp1a) and it appears to work for me on Ubuntu 20.04 AMD64.