Latest release references dist/cookies-eu-banner.js which doesn't exist.
SiAshbery opened this issue · comments
The main parameter in package.json refers to dist/cookies-eu-banner.js, which isn't included in the release itself, and as such hasn't been working properly for us unless we manually run npm run build in the downloaded node module.
Release 1.2.10 Included the dist/ folder and works fine as a result. Was there a specific reason it was removed and included in .gitignore?
Would it be easier to point main to src/cookies-eu-banner.js instead?
You right, I've just released the 1.2.14 which should fix that :)
@Alex-D same issue with the latest release 1.2.15.
Should be fixed in 1.2.16.
Sorry again ^^'
It works great now! Thanks.
Same issue now. The demo is also referencing dist/cookies-eu-banner.min.js so it doesn't work when you download the release.
The file is here in the latest release: https://github.com/Alex-D/Cookies-EU-banner/blob/1.2.16/dist/cookies-eu-banner.min.js
I did not understand your point :/
Also, the download button is not up to date. Use this one:
https://github.com/Alex-D/Cookies-EU-banner/archive/1.2.16.zip
Oh, I just used the download link and I didn't see the dist folder in the master branch.
No biggie. Thanks for your work!