AlessandroYorba / Alduin

A Vim Colorscheme

Geek Repo:Geek Repo

Github PK Tool:Github PK Tool

Bracket colour

opened this issue · comments

Love this theme, but there's just one thing..!

With my block cursor on the opening parenthesis, it actually looks like it's on the closing one:

focused

A funny this is, when that Vim window isn't focused, ie. I'm doing something in another window, it looks like this:

unfocused

Is that terminator? In my gnome-terminal I have the cursor blinking so then it is discernible, but still not obvious. I find myself always mistaking the cursor position.

My suggestion is a darker color for the "second" cursor.

It is Terminator!

@NightVigil, I'm not sure why the first parens isn't showing up, especially when you're in that active window. Were you able to solve the issue in Terminator?

@lathan @NightVigil you guys both bring up an interesting point about the second paren. I just push a new commit that changes how MatchParens works. I can see that it was difficult to discern the cursor location when editing files that do not have highlighting for paren operators, e.g. Python or C++ or many others. See if the new commit works better for you guys. Thanks for the feedback.

old behavior with vertical bar cursor
matchparen

New behavior with terminal vertical bar cursor
matchparennew

New behavior with terminal block cursor
blockcursor

I'm not seeing a difference with a block cursor. I'll debug it later, it might be another plugin interfering.

What I think needs to be done is to remove the bg color for the matching parenthesis and instead use underlining. This is what sublime text does by default. This is also done by termschool. At least this is what I would want and I think is an overall sane approach. I just have no idea how to write it in VimL.

I just added an new feature that we can try out. We can debate the color used but at least the underline option can be applied. Get the latest commit of alduin then add this to your vimrc:

  "Changes MatchParen to underline
  let g:alduin_Shout_AuraWhisper = 1
  colo alduin

underline

❤️❤️❤️❤️❤️❤️

Cool! I'll keep this ticket open incase someone else has any input.

The ":set number" numbers are slightly too dark :-)

Is it too dark for the default alduin mode or for let g:alduin_Shout_Become_Ethereal = 1 mode ? Or both?

Both. It might work better if it was the same as in the distinguished colour scheme...

I created a new Issue for the LineNr topic. I also have some screenshots for you to look at: #6

@lathan @NightVigil
heads up! I will be making a very slight modification to the AruraWhisper Shout in alduin. If you use it with the next commit you'll have to change your vimrc to

let g:alduin_Shout_Aura_Whisper = 1

Very minor I know but the spelling has been bugging me. Thanks again both of you for the feature suggestion

I have been struggling for some time with this...
Thanks for making this change :)
Maybe you can add this (and all the other) global config variable(s) in the readme so that they can be found easily?

@makkoncept good idea. I'll update the README and I'll add some comments in the colorscheme file.