Handle SIGTERM the same as SIGINT for triggering snarkos shutdown

Question

Handle SIGTERM the same as SIGINT for triggering snarkos shutdown

kyle-u410 opened this issue 2 months ago · comments

🚀 Feature

SIGTERM is an alias for SIGINT.

Motivation

Currently SIGINT is used to trigger shutdown with SIGTERM triggering immediate exit. This is non-standard. SIGTERM is the default termination signal used by most tools. The result of using SIGTERM is likely ledger corruption.

I have helped a number of validators (including ourselves) understand to modify tooling to use SIGINT. We can avoid this by keeping SIGINT handling the same and adding duplicate handling for SIGTERM.

Implementation

Add SIGTERM handlers which are the same as SIGINT.

Niklas Long · Answer 1 · Tue May 28 2024 21:15:46 GMT+0800 (China Standard Time)

Thanks for opening a feature request! We already handle INT, TERM, HUP and QUIT in the same way. Perhaps I am misunderstanding what you have in mind?

kyle-u410 · Answer 2 · Tue May 28 2024 22:47:04 GMT+0800 (China Standard Time)

Hey great. It looks like https://github.com/AleoNet/snarkOS/pull/3102/files already implemented this.

Sorry for the duplicate. It seem that by switching to SIGINT this helped some validators in Canary, but based on when the code was merged and the patch itself, there must have been another cause.

I will switch our tooling overback to SIGTERM and confirm expected behavior.