Do not work with 2.4.1

Question

Do not work with 2.4.1

mcherb opened this issue 8 years ago · comments

The name of the ColorPickerModule is changed to "e" when imported (Runtime error). I'm using the color picker in a module that is loaded in lazy mode (It works fine with angular version 2.1.0).

here is the error stack:

Sergio García Prado · Answer 1 · Mon Jan 09 2017 20:01:35 GMT+0800 (China Standard Time)

Same problem here

Janne Julkunen · Answer 2 · Tue Jan 10 2017 19:11:46 GMT+0800 (China Standard Time)

I have made a PR which fixes this library to be AOT compatible + some other fixes. You can try it by installing from here: git://github.com/zefoy/angular2-color-picker.git#npm-package

Code with working examples is available in aot-fixes branch if needed.

Joe Velez · Answer 3 · Sat Jan 14 2017 07:24:18 GMT+0800 (China Standard Time)

Mine broke somewhere along the line, I think when I upgraded to the (at the time) current version of 2.4.3. ... Since I'm testing/building my app (not ready for prod) I just took it out. Today I tested it again and it's working fine. I'm running @angular/core 2.4.3 Here's a snippet of my package.json

 "dependencies": {
    "@angular/common": "2.4.1",
    "@angular/compiler": "2.4.1",
    "@angular/core": "2.4.1",
    "@angular/forms": "2.4.1",
    "@angular/http": "2.4.1",
    "@angular/platform-browser": "2.4.1",
    "@angular/platform-browser-dynamic": "2.4.1",
    "@angular/router": "3.4.1",
    "@angular/upgrade": "2.4.1",
    "angular2-color-picker": "^1.3.0",
    "angular2-in-memory-web-api": "0.0.21",
    "bootstrap": "^3.3.7",
    "codemirror": "^5.21.0",
    "core-js": "^2.4.1",
    "dragula": "^3.7.2",
    "mdbootstrap": "^4.2.0",
    "ng2-bootstrap": "1.1.16-9",
    "ng2-charts": "^1.4.1",
    "ng2-codemirror": "^1.0.1",
    "ng2-dragula": "^1.2.2",
    "ng2-file-upload": "^1.1.4-2",
    "reflect-metadata": "^0.1.8",
    "rxjs": "^5.0.1",
    "systemjs": "0.19.41",
    "zone.js": "^0.7.2"
  },
  "devDependencies": {
    "concurrently": "3.1.0",
    "lite-server": "^2.2.0",
    "typescript": "^2.0.10"
  },

... but it's tough to keep up w/ the latest versions (not just my code, but third party libs, too).

Jimmy Aumard · Answer 4 · Sun Jan 29 2017 20:40:16 GMT+0800 (China Standard Time)

@sconix this repo seems abandoned by his owner, you should publish your version under npm under new name and enable issues if you want to support it, maybe allow some core maintainers can be a good things

Janne Julkunen · Answer 5 · Sun Jan 29 2017 21:24:40 GMT+0800 (China Standard Time)

Yes I am thinking of doing that since I would not mind to keep maintaining this. My current plan is that if I don't hear from @Alberplz soon I will make a new release with different name. At the same time I would like to make sure that the lib works with the upcoming Angular 4.

Has anybody seen any recommendations or have a good suggestion how to rename this library? I think now is anyway good time to release under different name Angular 4 is out quite soon, but I think they don't want everything named angular4-* and somehow ng2 makes also less sense once version 4 is out.

Jimmy Aumard · Answer 6 · Mon Jan 30 2017 16:09:10 GMT+0800 (China Standard Time)

@sconix why not just ng-color-picker and under description just say it's start at angular v2. Make sense for me since having the angular version under the package name doesn't make sense if multiple version are supported. Let us know when you publish it I'll switch to yours :) I'll see if I can help on it

Janne Julkunen · Answer 7 · Mon Jan 30 2017 16:14:12 GMT+0800 (China Standard Time)

Thanks, I will post here once I have published the new package.

It seems that people would prefer using ngx instead of ng. Which makes sense that leave ng for official stuff and ngx for 3rd party libs. I will already make a placeholder release and try make first release at the latest next week.

Alberto Pujante · Answer 8 · Mon Jan 30 2017 23:27:51 GMT+0800 (China Standard Time)

Ive been bussy but new release to 2.4 is published

Jimmy Aumard · Answer 9 · Tue Jan 31 2017 14:15:19 GMT+0800 (China Standard Time)

@Alberplz not working :( something went wrong on your publishing I think #81

mcherb · Answer 10 · Wed Feb 01 2017 21:35:24 GMT+0800 (China Standard Time)

works well for me, tks :)