AkhileshNS / heroku-deploy

A simple github action that dynamically deploys an app to heroku

Geek Repo:Geek Repo

Github PK Tool:Github PK Tool

When Heroku deploy fails action does not fail

hidr0 opened this issue · comments

  release:
    if: github.ref == 'refs/heads/main'
    name: "Release"
    needs: [build]
    runs-on: ubuntu-latest
    steps:
      - uses: actions/checkout@v1
      - uses: akhileshns/heroku-deploy@v3.12.12
        with:
          heroku_api_key: ${{secrets.HEROKU_API_KEY}}
          heroku_app_name: ${{secrets.HEROKU_APP_NAME}}
          heroku_email: ${{secrets.HEROKU_EMAIL}}

Screenshot 2021-11-17 at 15 27 41

I'm dealing with the same issue. Looks like we have the same case where a post-release command failed.

+1 for fixing this. I'm not sure where to start myself. Ruby is my forte, not Node.

There's not really a great way to do it. You can get the list of releases and compare before the deploy to after to see if the process succeeded or not.

Well, if you use the heroku cli you know what the returning code is. Why is it not possible here?