Aguafrommars / TheIdServer

OpenID/Connect, OAuth2, WS-Federation and SAML 2.0 server based on Duende IdentityServer and ITFoxtec Identity SAML 2.0 with its admin UI

Home Page:https://theidserver-duende.herokuapp.com/

Geek Repo:Geek Repo

Github PK Tool:Github PK Tool

OData exception (RavenDB)

ben-jacobs opened this issue · comments

Howdy :)

Pretty sure that And has to be and .... otherwise there's a syntax error thrown by OData.

GrantStore.cs

 protected virtual async Task<TEntity> GetEntityBySubjectAndClient(string subjectId, string clientId)
        {
            return (await _store.GetAsync(new PageRequest
            {
                Filter = $"{nameof(UserConsent.UserId)} eq '{subjectId}' **and** {nameof(UserConsent.ClientId)} eq '{clientId}'"
            }).ConfigureAwait(false)).Items.FirstOrDefault();
        }

This method is under unit test through : UserConsentStoreTest.GetUserConsentAsync_should_call_store_GetAsync and it doesn't throw. But, for coherence, I'll lowered case And

Haven't looked at the unit tests - but was definitely throwing with "And" and doesn't throw with "and" ... at least when using the RavenDB driver.

Have been away and just catching up with all the changes. Excellent progress! The library/app is definitely coming together nicely!