Project Mgmt: Add definition of done to Sherpa repository templates
oshoma opened this issue · comments
PROBLEM
We don't have a definition of done.
SOLUTION
Write one down, and put it in the issue templates.
OUTCOME
We'll have a shared understanding of what it means for a given piece of work to be complete. This will save us time and frustration by reducing rework and review cycles.
I realized Pull Requests are the place we really want this list, not issue templates.
mm I'm a bit confused. do we not want the "definition of done" to be
something we discuss upfront? like when we are deciding on which issue to
work on?
…On Wed, Nov 29, 2023 at 5:33 PM Oshoma Momoh ***@***.***> wrote:
I realized Pull Requests are the place we really want this list, not issue
templates.
—
Reply to this email directly, view it on GitHub
<#242 (comment)>,
or unsubscribe
<https://github.com/notifications/unsubscribe-auth/AD4OK5L3F4VRYO2ZS4ZWEE3YG6Z3VAVCNFSM6AAAAABAAFGZYSVHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMYTQMZSHAYDMNBSHA>
.
You are receiving this because you are subscribed to this thread.Message
ID: ***@***.***>
“Definition of done” is a generic list of conditions that all work should
satisfy before we agree it is complete. That’s iwhat I was working on in
this PR.
Then, for individual issues/features, there might also be a list of
acceptance criteria that’s issue-specific. Since that list is different for
every work item, we can’t template it.
For prioritizing what to work on next I think we would look at
value/impact, cost (time) and alignment with strategy.
On Wed, Nov 29, 2023 at 6:48 PM Amir Feizpour ***@***.***>
wrote:
… mm I'm a bit confused. do we not want the "definition of done" to be
something we discuss upfront? like when we are deciding on which issue to
work on?
On Wed, Nov 29, 2023 at 5:33 PM Oshoma Momoh ***@***.***>
wrote:
> I realized Pull Requests are the place we really want this list, not
issue
> templates.
>
> —
> Reply to this email directly, view it on GitHub
> <
#242 (comment)>,
> or unsubscribe
> <
https://github.com/notifications/unsubscribe-auth/AD4OK5L3F4VRYO2ZS4ZWEE3YG6Z3VAVCNFSM6AAAAABAAFGZYSVHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMYTQMZSHAYDMNBSHA>
> .
> You are receiving this because you are subscribed to this thread.Message
> ID: ***@***.***>
>
—
Reply to this email directly, view it on GitHub
<#242 (comment)>,
or unsubscribe
<https://github.com/notifications/unsubscribe-auth/AAAKWTZVSXLAL3JM3N3NACLYG7CUFAVCNFSM6AAAAABAAFGZYSVHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMYTQMZSHA3TOOBSGI>
.
You are receiving this because you were assigned.Message ID:
***@***.***>
I think I was confusing "definition of done" with "acceptance criteria".
the latter is what i meant
…On Wed, Dec 6, 2023 at 2:29 PM Oshoma Momoh ***@***.***> wrote:
Closed #242 <#242> as
completed via #243
<#243>.
—
Reply to this email directly, view it on GitHub
<#242 (comment)>,
or unsubscribe
<https://github.com/notifications/unsubscribe-auth/AD4OK5LDSSP52F6YMZMOINDYIDBQVAVCNFSM6AAAAABAAFGZYSVHI2DSMVQWIX3LMV45UABCJFZXG5LFIV3GK3TUJZXXI2LGNFRWC5DJN5XDWMJRGE3TENZXGE2DEOA>
.
You are receiving this because you commented.Message ID:
***@***.***>
I'll add acceptance criteria to the feature template.