Adyen / adyen-node-api-library

Adyen API Library for Node.js

Geek Repo:Geek Repo

Github PK Tool:Github PK Tool

please fix paymentInstrument type by making it nullable

naseemkullah opened this issue · comments

'paymentInstrument'?: PayAtTable.PaymentInstrumentEnum;

To have both cash and card as payment instruments, we must be able to unset any enum value (card or cash) that had been set by sending null. Please change the type to:

'paymentInstrument'?: PayAtTable.PaymentInstrumentEnum | null;

Hey @naseemkullah,

Thanks for bringing this to our attention. I just opened a quick PR to fix your issue and expect the next release (bi-weekly) to include said fix.

Best, Jilling
Adyen

amazing, thanks for the quick turnaround @jillingk

Hi @jillingk, seems like type is not updated in 16.0.2, still getting 'paymentInstrument'?: PayAtTable.PaymentInstrumentEnum; without the | null

fixed in 16.1.0