Giters

AdobeXD / xd-awesome

Awesome community-created resources for extending Adobe XD

Geek Repo:Geek Repo

Github PK Tool:Github PK Tool

Pull request template is slightly off base

ashryanbeats opened this issue · comments

commented

We should decide (and message clearly) if we want submissions to this repo in the form of issues or PRs. My vote is for PRs.

If we go with PRs, let's do the following:

  1. Update the pull request template to include the info from the issue template
  2. Reconsider what the issue template (and issues in general) on this repo are used for
  3. Make sure it's clear to developers how to submit for inclusion

If we go with issues, a slight variation of the above is in order.

commented

So, the initial thinking with Issue + PR was that the discussion of whether or not something would be accepted could be taken on the issue, whereas the PR was only created after approvals were given. The comments on the PR would then only be about the listing itself.

But I'm fine combining the two processes too.

commented

Not meaning to pressure you, but this is now open for quite a while without any progress. Is this still being "worked on" (i.e., getting discussed or something like this)? Otherwise, if it'll stay the way it currently is, I'd suggest closing the issue 😉 (since folks should get encouraged to suggest repo's, an issue that's open for a long time without any progress isn't good for the repo's "reputation")...

commented

My vote here is to go straight to PR as well. Since we will be reviewing the PRs anyways, removing an extra review step would make this process more efficient. Since @kerrishotts mentioned she'd be fine with combining the two processes, I think we should move to the new, streamlined process. I will work on this.

Issues will be used to raise issues of the existing listings (for example, listing no longer working or having significant bugs)

commented

Thanks Steve! Sounds like a plan. Let's make sure it's clear in:

  • Issue template
  • PR template
  • The "Contributing" section of the readme
commented

@dkstevekwak The "Contributing" section of the README.md still has wrong instructions about contribution (cf. https://github.com/AdobeXD/xd-awesome#contributing), I'll, therefore, reopen the issue.

commented

@pklaschka thanks for pointing that out. Addressed - 7acd037