DNS64 config option causes segfault

Question

DNS64 config option causes segfault

suffieldacademy opened this issue a year ago · comments

Network Administrator commented a year ago

Was trying out the DNS64 configuration and noticed the process kept crashing on startup. Thought it was an issue with my YAML but realized it was the dns64 config option. Even the command-line argument causes it to crash:

dnsproxy --upstream=::1 --bootstrap=::1 --dns64
2023/09/06 15:25:54 [info] Starting dnsproxy v0.54.0
panic: runtime error: invalid memory address or nil pointer dereference
[signal SIGSEGV: segmentation violation code=0x1 addr=0x8 pc=0x8c3546]

goroutine 1 [running]:
main.initDNS64(0xc00013f628, 0xc0000bb8c0?)
	github.com/AdguardTeam/dnsproxy/main.go:569 +0x46
main.createProxyConfig(_)
	github.com/AdguardTeam/dnsproxy/main.go:344 +0x22d
main.run(0xc0000bb8c0)
	github.com/AdguardTeam/dnsproxy/main.go:258 +0x1c7
main.main()
	github.com/AdguardTeam/dnsproxy/main.go:237 +0x44f

Eugene · Answer 1 · Fri Sep 08 2023 20:01:23 GMT+0800 (China Standard Time)

@suffieldacademy, hello again. Could you please try the master version now? It should fix this exact validation step, additionally requiring the --private-rdns-upstream option, see the README.md.

Network Administrator · Answer 2 · Fri Sep 08 2023 20:33:09 GMT+0800 (China Standard Time)

Just compiled and tried it, looks much better! Not sure of the ticket etiquette here (do you close issues or do I?) so happy to close this if you're ready.

Thanks for the quick fix.

Eugene · Answer 3 · Fri Sep 08 2023 21:54:21 GMT+0800 (China Standard Time)

@suffieldacademy, closing the issue you've opened is appreciated. Thanks.