Errors? when initial idf values in testing part.

[WonderMind]

Hi zhuyun,
Please help me check this problem:

K-NRM/knrm/data/generator.py

Line 93 in fa5d60c

 idf = np.array([int(t) for t in cols[2].split(',')]) 

I think when 'with_idf=True', this line should be:
if len(cols) < 3:
idf = np.ones(len(q))
else:
idf = np.array([int(t) for t in cols[2].split(',')])

all right?

Thanks for you attention.

[Dai Zhuyun (戴竹韵)]

Hi, Yes, you are correct about this. Thank you!

On Fri, Nov 23, 2018 at 3:14 AM EdwardLorenz ***@***.***> wrote: Hi zhuyun, Please help me check this problem: https://github.com/AdeDZY/K-NRM/blob/fa5d60c38d894c3ef6cc7e580f60938773c3a8b3/knrm/data/generator.py#L93 I think when 'with_idf=True', this line should be: if len(cols) < 3: idf = np.ones(len(q)) else: idf = np.array([int(t) for t in cols[2].split(',')]) all right? Thanks for you attention. — You are receiving this because you are subscribed to this thread. Reply to this email directly, view it on GitHub <#13>, or mute the thread <https://github.com/notifications/unsubscribe-auth/AE8DmAxOZb0ktoyfz1FkjG96qqfKDfwtks5ux65qgaJpZM4YwPyr> .

-- Zhuyun Dai Language Technologies Institute School of Computer Science Carnegie Mellon University