Giters

Addepar / ember-charts

Home Page:https://opensource.addepar.com/ember-charts/

Geek Repo:Geek Repo

Github PK Tool:Github PK Tool

Ember 1.9, 1.10+ Support

dylnuge opened this issue · comments

commented

Ember 1.9 included an upgrade from Handlebars 1.0 to Handlebars 2.0, and Ember 1.10 replaced the templating library with HTMLBars. Because ember-charts packages pre-compiled templates in our dist files, it's not possible for us to support future versions of Ember while also continuing to support users of ember-charts who have not yet upgraded.

Our ideal strategy for dealing with this problem is to move to ember-cli, however we need a solution for the meantime and we need a solution that supports ember-charts users who are not on ember-cli and are planning to continue using our globals build.

@ebryn, @azirbel, @igillis and I have all discussed this and come up with the following strategy:

  • The current code on ember-charts master, which includes dist files that work with Ember 1.8 and earlier, will be released one last time as ember-charts 0.4.0. This will be the final ember-charts release to support Ember 1.8 and earlier. (Update: this has now been done)
  • The Handlebars 2.0 upgrade (#65) will be merged, and released as ember-charts 0.5.0. This will be the only release of ember-charts to support Ember 1.9.
  • The HTMLBars upgrade (#76) will be merged, and released as ember-charts 0.6.0. This will be the first version of ember-charts to support Ember 1.10+. Going forward, all future releases of ember-charts will be compiled for Ember 1.10+.

For users who are still on versions of Ember before 1.10, our recommended action is to upgrade as soon as possible. In the meantime, as new features and bugfixes are brought into the ember-charts library, it will remain possible to manually cherry-pick them and build your own dist files for older versions of Ember.

commented

Is there an ETA on the 0.5.0 release? Is the ebryn/handlebars-2.0 branch the place where the main work for this upgrade is happening?

Thanks.

commented

Yes, the ebryn/handlebars-2.0 branch is where the work for the upgrade is happening. We're still testing a few things but I hope to have 0.5.0 and 0.6.0 both released very soon!

commented

Great! I'm in the process of upgrading our app to ember 1.9, and pulled in that branch and haven't had any issues, so things are working well for our usecase with the work y'all have done so far.

Thanks!

commented

Excellent, glad to hear it! Please report any issues you run into 😄

commented

Hi, I am using ebryn/htmlbars branch with ember 1.10/htmlbars in my app without any issues. Great work.
Thanks

commented

Hi @dylnuge,

Any updates on releasing ember-charts, latest version? We are in the process of moving to ember-cli module. Due to ember-charts dependency we were unable to move to any ember latest versions.

commented

fwiw, to get the ebryn/htmlbars to work on ember 1.11, you need to set the revision field in the template function.
Add this after line 20 of the non-minified dist/ember-charts.js file:

    revision: "Ember@1.11.1",
commented

Any progress on getting ember-charts to work with ember-cli?

commented

I have a working branch on Ember 2.0 but I'm having difficulty back porting it to pre 2.0. The naming conventions are off. Any help would be appreciated. https://github.com/WorkshopDigital/ember-charts/tree/addon

commented

Thanks for your patience.

Ember Charts is now available as an Ember-CLI addon which solves the support for Ember 1.9 and Ember 1.10 ( See #112 )