Use less generic names for LESS variables
nragaz opened this issue · comments
For example, @label-color (default value: #888) conflicts with Bootstrap's @label-color (default value: #fff). Unless I'm missing something, the only way around this is to manually redefine the whole style (in this case, svg text { fill: #888; } later on in your LESS.
I feel that something like @ember-charts-label-color would be better (Bootstrap should probably do the same, but...).
That's a good idea.
I 100% agree. I personally don't like the way this was done, its a bad habit we started. I wasn't here when when this was set up back in the day, but from what I can tell (based on other projects) this was actually done purposefully. That was our easy way of tweaking Bootstrap to look how we wanted, thanks to LESS's weird variable scope.
If we do rename these variables, we will need to check to make sure we don't cause changes elsewhere (not necessarily charts itself, but other projects that use it). Since for example, @label-color is used elsewhere in Bootstrap and would no longer be updated to our new color, which we may or may not have been relying on.