Giters

Actyx / Actyx

Local-First Cooperation based on Event Sourcing

Home Page:https://developer.actyx.com

Geek Repo:Geek Repo

Github PK Tool:Github PK Tool

Update OpenSSL on the Wix builder

jmg-duarte opened this issue · comments

commented

Partially closed by #498

For context, 3 days of work were spent trying to upgrade OpenSSL and building osslsigncode from it, the build was fragile and didn't work without "hacks". I've decided to go back and just re-add signing. When we actually need to upgrade, this task will hopefully be made easier by the package managers.

For future reference, the image dactiv/wix can be used to build the MSI on Docker, to integrate signing I recommend doing a multistage build that builds osslsigncode and then just uses that binary, keeping the final Docker image small.

commented

Thanks for writing this up! I think we can close this for now.