ActiveCampaign / mailmason

A complete toolset to streamline building and updating a set of consistent transactional emails.

Home Page:https://postmarkapp.com/mailmason

Geek Repo:Geek Repo

Github PK Tool:Github PK Tool

secrets.json is required?

mathiasmadsen opened this issue · comments

Hi, I have just initiated the development of a project using mailmason. It looks very promising :)

When following your guide, it is stated that secrets.json is not required. However, I was met with the following error when using 'npm start':
..ERROR
>> Unable to process task.
Warning: Required config property "watch" missing.

When secrets.json was created everything works, so I expect there is some kind of ignore-function that is not activated?

Thanks, Mathias. My guess is that this is just an oversight on our part. The secrets are only necessary if you're using sending or FTP'ing, but the file itself is probably a dependency in there.

@derekrushforth Is there an easy way to have Grunt look the other way when the secrets.json file is missing? Or should we update the documentation to explain that while you don't have to populate secrets, the file itself should be present?

Thanks for letting us know about this, @mathiasmadsen. I just merged a fix so that secrets.json is optional. Let me know if this works for you.

Same problem here, with the latest version from Github. When I run npm start, I get an infinite loop of this error:

Verifying property watch exists in config...ERROR
>> Unable to process task.
Warning: Required config property "watch" missing.

Hey @Spone, have you added a JSON config from this step? Seems like that may be causing your issue since the config is required to build your emails.

I need to update the wiki so it's clearer that config.json is required and secrets.json is optional.

Thanks for the reply. I have both config.json and secrets.json in the root folder.

@Spone Do you see any comments at the top of those JSON files?

Good catch! I forgot to remove the comments 😓

Maybe a more explicit error message when the JSON files are invalid?

@Spone Glad that fixed it! Unfortunately, we have no control over this error message since it's coming from one of the grunt plugins. I know this can be a pain because I've come across this too ☹️

We may consider removing the comments from the example configs entirely if this becomes a bigger issue.