Bug Regarding Volume Control
Elwood0 opened this issue · comments
Great work on the extender for Into the Breach. One thing I noticed while using it, however, is that it makes the volume scrollers unusable for some reason, preventing you from unselecting once you click them. Other than that though, it works great. Thanks.
Found the issue: this is due to Ui:mouseup() always returning true when it's clicked. Which happens to be always when there's no child UI element under the mouse.
The only reason this bug isn't more prominent is due to the game handling most mouse clicks on mouseDown, which isn't intercepted nearly as aggressively. I'd suggest changing Ui:clicked() to return true only if it actually implemented a handler (and possibly only if the handler itself returned true as well), and then returning that value in mouseup().
Note: this same bug also prevents multiple UiRoots from working nicely together. Only the first root created (I think?) will process mouse clicks correctly. Also prevents weapon swapping on mechs when there is a UiRoot present between missions.