ARM-software / CMSIS-Driver

Repository of microcontroller peripheral driver implementing the CMSIS-Driver API specification

Home Page:https://arm-software.github.io/CMSIS-Driver/

Geek Repo:Geek Repo

Github PK Tool:Github PK Tool

ESP32 ARM_WIFI_Initialize callback parameter not checked for NULL

xennex22 opened this issue · comments

ARM_WIFI_Initialize takes a callback parameter cb_event. This is only used for ARM_WIFI_EVENT_AP_CONNECT and ARM_WIFI_EVENT_AP_DISCONNECT.

According to help the cb_event parameter can be NULL if no callback signals are required, however if AT_NOTIFY_STATION_CONNECTED or AT_NOTIFY_STATION_DISCONNECTED events are generated then the event callback is called without checking it if is NULL.

This occurs if the connection to the remote host drops for some reason.

pCtrl->cb_event (ARM_WIFI_EVENT_AP_CONNECT, mac);

Probably just needs a preceding test if(pCtrl->cb_event)

You are right again, this check shall be added. Thanks for taking the time and reporting this!