Giters

AOtools / soapy

A Python Adaptive Optics Simulation

Geek Repo:Geek Repo

Github PK Tool:Github PK Tool

LGS elongation

GillesOrban opened this issue · comments

commented

Hi,

LGS elongation does not work when using ShackHartmann and one have to use ShackHartmannLegacy to be able to used it. This is because lineofsight.py and lineofsight_legacy.py diverge significantly.
Not sure what is the idea, what was the motivation to have legacy files, and how much the legacy versions might be outdated.
Modifying base.py and lineofsight.py to make the LGS elongation works do not seem trivial to me.
What is your advice or plan here?
Thanks

commented

From discussion wiht @ojdf - In the new concept, a new "LineOfSIght" object would be required for each "elongation point" along the LGS beacon. Hopefully this works with the current SH and LOS, and is a bit more elegant internally.