macOS build fails due to undeclared identifier `CLOCK_MONOTONIC_COARSE`

[Ben Wibking]

Describe the bug
afl-common.c uses a symbol that does not exist in time.h:

src/afl-common.c:999:38: error: use of undeclared identifier 'CLOCK_MONOTONIC_COARSE'; did you mean '_CLOCK_MONOTONIC_RAW'?

To Reproduce
Steps to reproduce the behavior:

1. gmake on macOS 14
2. See error.

Expected behavior
A clear and concise description of what you expected to happen.

Screen output/Screenshots

➜  AFLplusplus git:(dev) gmake
[*] Compiling AFL++ for OS Darwin on ARCH arm64
[!] Note: skipping x86 compilation checks (AFL_NO_X86 set).
[+] shmat seems to be working.
[-] You seem to need to install the package python3-dev or python-dev (and perhaps python[3]-apt), but it is optional so we continue
[+] Everything seems to be working, ready to compile. (Apple clang version 15.0.0 (clang-1500.1.0.2.5))
cc -O2   -g -Wno-pointer-sign -Wno-variadic-macros -Wall -Wextra -Wno-pointer-arith -fPIC -I include/ -DAFL_PATH=\"/usr/local/lib/afl\" -DBIN_PATH=\"/usr/local/bin\" -DDOC_PATH=\"/usr/local/share/doc/afl\" -flto=full  -c src/afl-common.c -o src/afl-common.o
src/afl-common.c:999:38: error: use of undeclared identifier 'CLOCK_MONOTONIC_COARSE'; did you mean '_CLOCK_MONOTONIC_RAW'?
  int             rc = clock_gettime(CLOCK_MONOTONIC_COARSE, &ts);
                                     ^~~~~~~~~~~~~~~~~~~~~~
                                     _CLOCK_MONOTONIC_RAW
/Library/Developer/CommandLineTools/SDKs/MacOSX.sdk/usr/include/time.h:159:1: note: '_CLOCK_MONOTONIC_RAW' declared here
_CLOCK_MONOTONIC_RAW __CLOCK_AVAILABILITY = 4,
^
src/afl-common.c:1016:38: error: use of undeclared identifier 'CLOCK_MONOTONIC_COARSE'; did you mean '_CLOCK_MONOTONIC_RAW'?
  int             rc = clock_gettime(CLOCK_MONOTONIC_COARSE, &ts);
                                     ^~~~~~~~~~~~~~~~~~~~~~
                                     _CLOCK_MONOTONIC_RAW
/Library/Developer/CommandLineTools/SDKs/MacOSX.sdk/usr/include/time.h:159:1: note: '_CLOCK_MONOTONIC_RAW' declared here
_CLOCK_MONOTONIC_RAW __CLOCK_AVAILABILITY = 4,
^
2 errors generated.
gmake: *** [GNUmakefile:466: src/afl-common.o] Error 1

Additional context
N/A

[Ben Wibking]

The same error appears when using the Homebrew version of LLVM/Clang:

 ➜  AFLplusplus git:(dev) gmake
[*] Compiling AFL++ for OS Darwin on ARCH arm64
[!] Note: skipping x86 compilation checks (AFL_NO_X86 set).
[+] shmat seems to be working.
[-] You seem to need to install the package python3-dev or python-dev (and perhaps python[3]-apt), but it is optional so we continue
[+] Everything seems to be working, ready to compile. (Homebrew clang version 17.0.6)
clang -O2   -g -Wno-pointer-sign -Wno-variadic-macros -Wall -Wextra -Wno-pointer-arith -fPIC -I include/ -DAFL_PATH=\"/usr/local/lib/afl\" -DBIN_PATH=\"/usr/local/bin\" -DDOC_PATH=\"/usr/local/share/doc/afl\" -flto=full  -c src/afl-common.c -o src/afl-common.o
src/afl-common.c:999:38: error: use of undeclared identifier 'CLOCK_MONOTONIC_COARSE'; did you mean '_CLOCK_MONOTONIC_RAW'?
  999 |   int             rc = clock_gettime(CLOCK_MONOTONIC_COARSE, &ts);
      |                                      ^~~~~~~~~~~~~~~~~~~~~~
      |                                      _CLOCK_MONOTONIC_RAW
/Library/Developer/CommandLineTools/SDKs/MacOSX14.sdk/usr/include/time.h:159:1: note: '_CLOCK_MONOTONIC_RAW' declared here
  159 | _CLOCK_MONOTONIC_RAW __CLOCK_AVAILABILITY = 4,
      | ^
src/afl-common.c:1016:38: error: use of undeclared identifier 'CLOCK_MONOTONIC_COARSE'; did you mean '_CLOCK_MONOTONIC_RAW'?
 1016 |   int             rc = clock_gettime(CLOCK_MONOTONIC_COARSE, &ts);
      |                                      ^~~~~~~~~~~~~~~~~~~~~~
      |                                      _CLOCK_MONOTONIC_RAW
/Library/Developer/CommandLineTools/SDKs/MacOSX14.sdk/usr/include/time.h:159:1: note: '_CLOCK_MONOTONIC_RAW' declared here
  159 | _CLOCK_MONOTONIC_RAW __CLOCK_AVAILABILITY = 4,
      | ^
2 errors generated.
gmake: *** [GNUmakefile:466: src/afl-common.o] Error 1

[David CARLIER]

The compiler does not matter, macos libc just does not support it. Doing something like '#define CLOCK_MONOTONIC_COARSE CLOCK_MONOTONIC` for mac in appropriate place(s) should work.

[Ben Wibking]

Ok, that works. This patch fixes it:

diff --git a/src/afl-common.c b/src/afl-common.c
index a956fef9..e1533169 100644
--- a/src/afl-common.c
+++ b/src/afl-common.c
@@ -32,6 +32,8 @@
 #ifndef __USE_GNU
   #define __USE_GNU
 #endif
+#define CLOCK_MONOTONIC_COARSE CLOCK_MONOTONIC
+
 #include <string.h>
 #include <strings.h>
 #include <time.h>

[David CARLIER]

feel free to open a PR :)

[van Hauser]

@devnexen do you know if CLOCK_MONOTONIC_COARSE exists on netbsd?

[David CARLIER]

I doubt it but let me check.

[David CARLIER]

Well not in native mode :) and the Linux compatibility layer returns ENOTSUP with this constant.

[Ben Wibking]

Fixed by 29544e4.

[van Hauser]

Thanks for reporting!