AFLplusplus / AFLplusplus

The fuzzer afl++ is afl with community patches, qemu 5.1 upgrade, collision-free coverage, enhanced laf-intel & redqueen, AFLfast++ power schedules, MOpt mutators, unicorn_mode, and a lot more!

Home Page:https://aflplus.plus

Geek Repo:Geek Repo

Github PK Tool:Github PK Tool

INSTALL.md instructions for Mac missing accounting for different homebrew paths (I think)

seanm opened this issue · comments

The INSTALL.md instructions for Mac say:

# Depending on your MacOS system + brew version it is either
export PATH="/opt/homebrew/opt/llvm/bin:$PATH"
# or
export PATH="/usr/local/opt/llvm/bin:$PATH"
# you can check with "brew info llvm"

export PATH="/usr/local/opt/coreutils/libexec/gnubin:/usr/local/bin:$PATH"

Regarding the last line: I don't have a /usr/local/opt/coreutils/libexec/gnubin: directory.

I think this should have an "or" like the lines above, ie:

export PATH="/opt/homebrew/opt/coreutils/libexec/gnubin:/usr/local/bin:$PATH"
# or
export PATH="/usr/local/opt/coreutils/libexec/gnubin:/usr/local/bin:$PATH"

ok done.
in the future please send a pull request with the recommended changes.
None of us is a mac user hence keeping the information for mac (or the implementation) correct with the many changes that apple does with every release is difficult.

in the future please send a pull request with the recommended changes.

I would have, but I created an Issue first because I was not sure if I was correct or not. Even with the change, the instructions do not work for me (see #1865)

None of us is a mac user hence keeping the information for mac (or the implementation) correct with the many changes that apple does with every release is difficult.

Yeah, Apple's fast and aggressive changes can be annoying, but in fairness, this seems to be because of homebrew, not Apple.

I believe I've found your change here: 602ecee#diff-93adeedb62ae4160af1d8713c9f15796d7b6312d45a0148447538fe185cd7347

It doesn't seem correct to me; at least, it is not what I was suggesting. (But as I still don't have afl working properly on macOS, I can't be sure...)

I was thinking something like this: #1995