Workingcopy3 review notes
mgrusin opened this issue · comments
-
Looks really good!
-
For the punch-out at the top of the board, you probably (?) don't need the line of drill hits on the bottom edge (that are effectively in the route out below it).
-
Also, I'd suggest either pre-removing the above section (I'm guessing a user will always need to do this to connect USB), or dividing it with a route-out vertically down the middle to make it easier to snap off each half. BUT this will only work if you ensure that ground is available on both sides, which it may not currently be.
-
For the traces that go through the mouse bites, spend a bit of time to ensure they're right down the center. (When I was prototyping LilyMini with a very similar design, someone from Advanced Circuits called me concerned about the drill tolerances in this situation.)
-
Unless I missed them, consider adding 4.7k pull-up resistors for the I2C bus at the processor, preferably with a 3-way jumper on the VCC side so they can be disabled if necessary. The weak PUs on the I/O lines can be used instead, but in general they're not as reliable (I don't recall the SAMD specifics in this regard).
-
(Minor) J29 and J19, and J17 and J28 overlay each other on the schematic.
Those are the things I noticed at first glance, I'll keep looking and add to this if I have other suggestions.
Again super cool board, can't wait to see it up and running.
-
The punch out on the USB was to reduce the number of corners. Right now it sits at 5 which was the maximum number of points for gold phoenix's simple shape specs. Now we are going with Osh Park we can probably do something like that. Though this implementation was nice on the protos we got in. I'll see what it does to the ground plane and make a decision from there.
-
I must have deleted the pull-ups when I removed the motor driver. Thank you for catching that. Could have been bad.
-
Mouse bit traces fixed.
-
Yea, schematic aesthetics will get attention once the Hardware is on order. :)