Refactor of utilities and experiment functions
ADGEfficiency opened this issue · comments
Currently I have utilities in
scripts/utils.py
scripts/tf_utils.py
scripts/experiment.py
I also find it awkward to have the experiment() function in scripts - I feel it should be in /experiments
Propose
1 - remove all utils from experiment.py into either utils, tf_utils or experiment/expt_utils.py
2 - move experiment() and Runner from scripts/experiment.py, maybe into experiment/ or common/experiment
3 - move all utils into common/utils
Essentially I'd like to refactor all of the code out of /scripts
spaces.py can go into envs
schedulers and processors shouldn't be needed now, but will keep around, maybe just in /common/
Related to this is the issue of where config files live for the config_expt.py
Currently the setup for each experiment lives in experiment/results/expt_name/common.ini run_configs.ini
This makes it awkward to remove results from an experiment as you can't just rm -r results/expt_name as you will remove the config files too
Moved the code from energy_py/scripts into energy_py/common
Spaces have stayed in common
Made a final refactor of utils - separated out logging into energy_py/common/logging.py and the numpy functions into common/np_utils.py
The issue of where config files should live still remains - going to close this issue and reopen another issue specifically to where config files should live