ACEmulator / ACE

Asheron's Call server emulator.

Home Page:https://emulator.ac

Geek Repo:Geek Repo

Github PK Tool:Github PK Tool

Export-SQL Recipe Throws Errors on Invalid Recipe

nwg5817 opened this issue · comments

Bug Report

  • [ X] bug report ->
    Export-SQL for Recipes is not working as intended. If you delete a regular weenie, and then try to export it you will be given a console output.
    ACE >> 2022-12-04 22:11:30,587 INFO : Couldn't find weenie 4880

If you delete a recipe and try to export it, ExportSQLRecipe will error out. It should be returning "Couldn't find recipe id"

Repro steps.

Delete a recipe weenie from the DB.
Try to export-sql #### recipe

The log given by the failure.

2022-12-04 22:09:43,467 ERROR: Exception while invoking command handler for: @export-sql 4880 recipe
System.ArgumentOutOfRangeException: Index was out of range. Must be non-negative and less than the size of the collection. (Parameter 'index')
at System.Collections.Generic.List`1.get_Item(Int32 index)
at ACE.Server.Command.Handlers.Processors.DeveloperContentCommands.ExportSQLRecipe(Session session, String param) in F:~Modding\Asheron's Call\ACE\Source\ACE.Server\Command\Handlers\DeveloperContentCommands.cs:line 2213
at ACE.Server.Command.Handlers.Processors.DeveloperContentCommands.HandleExportSql(Session session, String[] parameters) in F:~Modding\Asheron's Call\ACE\Source\ACE.Server\Command\Handlers\DeveloperContentCommands.cs:line 2073
at ACE.Server.Command.CommandManager.CommandThread() in F:~Modding\Asheron's Call\ACE\Source\ACE.Server\Command\CommandManager.cs:line 103

Desired functionality.

What would like to see implemented? Console Output notifying user that recipe ID is invalid.
What is the use case? If exporting all recipes, it will break the process and halt at the invalid ID. This does not happen for regular weenies.