A11yance / aria-query

Programmatic access to the ARIA specification

Geek Repo:Geek Repo

Github PK Tool:Github PK Tool

Version 5.2.0 doesn't specify `deep-equal` as a dependency, but still tries to `require` it

TomerAberbach opened this issue · comments

Go to https://www.npmjs.com/package/aria-query?activeTab=code and then lib/elementRoleMap.js and you can see the transpiled file contains the following line:

var _deepEqual = _interopRequireDefault(require("deep-equal"));

This fails because deep-equal isn't installed.

Copying over my comment from #497

It's used on this line in the file on npm, but it's been already converted to dequal. The only reference to deep-equal I can find in this repo now is in a flow definitions file.

Building it locally gives me the correct "dequal" import.

Alright, let's get that fixed. New version inbound in a few minutes.

So weird, it's like npm publish didn't run npm build. :/

Fixed in v5.2.1

I need to investigate why npm publish doesn't run npm build.

@TomerAberbach does version v5.2.1 fix the issue for you?

Yup, solved for me. Thanks!