Support for landmark roles

Question

Support for landmark roles

darekkay opened this issue 4 years ago · comments

Hello,
as described in this issue from dom-testing-library, the <header> element role is not identified correctly. According to the specs, the implicit role for <header> is banner.

As noticed by @OCmilo, aria-query does not handle any landmark roles. Is there a plan to support them? I could also have a look into this.

Darek Kay · Answer 1 · Tue May 26 2020 04:38:00 GMT+0800 (China Standard Time)

Sorry, I should have checked the PRs in more detail first. It seems to be addressed in #46 already. Looking forward to it!

J. Renée Beach · Answer 2 · Sat Jun 13 2020 02:51:59 GMT+0800 (China Standard Time)

@darekkay #46 landed today. Working on a release within the next week.

Darek Kay · Answer 3 · Fri Jun 19 2020 14:46:25 GMT+0800 (China Standard Time)

@jessebeach thanks for all the hard work! However, the issue is still reproducable. The banner role file does not include any header reference. It should work similar to contentinfo, but with slightly different constraints:

The HTML header element defines a banner landmark when its context is the body element.
The HTML header element is not considered a banner landmark when it is descendant of any of following elements:

article
aside
main
nav
section

I think this line is the main problem - it should be header instead of banner, then the mapping works correctly. However, the other constraints have to be added to fully fulfil the ARIA specs. This requires much more work, though.

Can you please re-open the issue?