Implicit `code` role for `code` element
MatanBobi opened this issue · comments
Hi!
As a follow up for testing-library/dom-testing-library#1100
It looks like the ARIA spec added an implicit role code for the code HTML element.
https://www.w3.org/TR/html-aria/
We'd be happy for a fix here so we'll also get it in testing-library :)
Thanks for your help! :)
@MatanBobi if I'm not mistaken this will be available in the next version.
The PR #447 should've fixed it.
Because an issue from dom-testing-library is mentioned, I wanted to piggy back on this and also mention another issue testing-library/dom-testing-library#1201 which will also be fixed.
Yeah @timdeschryver, I missed that because I was only looking at the README of this project and it didn't mention code role so I guess this should also be updated. And yeah it looks like the other should also be resolved :) Thanks for catching this.
I'll close this one :)