Giters

A11yance / aria-query

Programmatic access to the ARIA specification

Geek Repo:Geek Repo

Github PK Tool:Github PK Tool

Please replace dependency

Semigradsky opened this issue · comments

commented

Please replace deep-equal with more widespread, fast, and lightweight fast-deep-equal.

I tried to send PR, but I am not familiar with flow and have issues with installing.
As I understand, it is enough to change line

aria-query/src/elementRoleMap.js

Line 5 in 1f1802d

import deepEqual from 'deep-equal';

to import deepEqual from 'fast-deep-equal/es6';

commented

I appreciate the concern. I'm going to stick with deep-equal. A collaborator of mine is the author of it and it does what it needs to do well enough.

commented

No doubt it is well written, but it's a surprisingly heavy dependency -- installing it pulls in 50 other packages, which is a little unfortunate. The node ecosystem in general has a bit of trouble with excessive numbers of dependencies.

commented

I agree, deep-equal does a lot of things like typed array support or map/set support that aria-query doesn't use. Would you accept a PR to replace the dependency with a simple deep equal utility function in this project instead?