62832 / MEGACells

ME Greater Accumulation Cells - For when kilobytes just won't do.

Home Page:https://www.curseforge.com/minecraft/mc-mods/mega-cells

Geek Repo:Geek Repo

Github PK Tool:Github PK Tool

Latest Update causes Server Watchdog Crash on Startup

LokeYourC3PH opened this issue · comments

commented

What the title says. The latest update causes the server to hang on startup with the following crashlog:
crash-2023-08-29_13.40.25-server.txt

commented

That's very concerning. I'll have to investigate.

I have an infinit loading scrren when loading a world.

commented

I have an infinit loading scrren when loading a world.

Is this also happening on Fabric or is it also an issue on Forge?

I have only tested it on Fabric.

commented

I'm unable to reproduce this so far in either development or production. Are you playing a larger pack?

Yes, I am going to start testing the mods individually.

commented

Turns out I've made a glaring mistake with the bulk compression service that's making it do more than double the work for each individual chain of compressible items. I'll be adapting this and releasing a fix as soon as possible.

Ithink i got it.
This combination of mods breaks it.

16:16:26.580
launcher
main
Using default game log configuration client-1.12.xml (outputs XML)
16:16:29.530
FabricLoader/GameProvider
main
Loading Minecraft 1.20.1 with Fabric Loader 0.14.22
16:16:29.954
FabricLoader
main
Loading 79 mods:
	- ae2 15.0.7-beta
	   \-- team_reborn_energy 3.0.0
	- architectury 9.1.12
	- cloth-config 11.1.106
	   \-- cloth-basic-math 0.6.1
	- fabric-api 0.86.1+1.20.1
	   |-- fabric-api-base 0.4.30+7abfd51577
	   |-- fabric-api-lookup-api-v1 1.6.35+4d8536c977
	   |-- fabric-biome-api-v1 13.0.10+b3afc78b77
	   |-- fabric-block-api-v1 1.0.9+e022e5d177
	   |-- fabric-blockrenderlayer-v1 1.1.40+b3afc78b77
	   |-- fabric-client-tags-api-v1 1.1.1+97bb207577
	   |-- fabric-command-api-v1 1.2.33+f71b366f77
	   |-- fabric-command-api-v2 2.2.12+b3afc78b77
	   |-- fabric-commands-v0 0.2.50+df3654b377
	   |-- fabric-containers-v0 0.1.62+df3654b377
	   |-- fabric-content-registries-v0 4.0.9+b3afc78b77
	   |-- fabric-convention-tags-v1 1.5.4+a1a980da77
	   |-- fabric-crash-report-info-v1 0.2.18+aeb40ebe77
	   |-- fabric-data-generation-api-v1 12.2.1+1e61dba177
	   |-- fabric-dimensions-v1 2.1.52+b3afc78b77
	   |-- fabric-entity-events-v1 1.5.22+b3afc78b77
	   |-- fabric-events-interaction-v0 0.6.1+e91849a877
	   |-- fabric-events-lifecycle-v0 0.2.62+df3654b377
	   |-- fabric-game-rule-api-v1 1.0.38+b04edc7a77
	   |-- fabric-item-api-v1 2.1.27+b3afc78b77
	   |-- fabric-item-group-api-v1 4.0.10+23d9108177
	   |-- fabric-key-binding-api-v1 1.0.36+fb8d95da77
	   |-- fabric-keybindings-v0 0.2.34+df3654b377
	   |-- fabric-lifecycle-events-v1 2.2.21+b3afc78b77
	   |-- fabric-loot-api-v2 1.1.39+b3afc78b77
	   |-- fabric-loot-tables-v1 1.1.43+9e7660c677
	   |-- fabric-message-api-v1 5.1.7+3265161977
	   |-- fabric-mining-level-api-v1 2.1.49+b3afc78b77
	   |-- fabric-model-loading-api-v1 1.0.2+709a987177
	   |-- fabric-models-v0 0.4.1+9386d8a777
	   |-- fabric-networking-api-v1 1.3.9+b3afc78b77
	   |-- fabric-networking-v0 0.3.49+df3654b377
	   |-- fabric-object-builder-api-v1 11.1.1+6beca84877
	   |-- fabric-particles-v1 1.1.1+201a23a077
	   |-- fabric-recipe-api-v1 1.0.19+b3afc78b77
	   |-- fabric-registry-sync-v0 2.3.1+4df89eb277
	   |-- fabric-renderer-api-v1 3.1.1+9386d8a777
	   |-- fabric-renderer-indigo 1.4.1+9172968c77
	   |-- fabric-renderer-registries-v1 3.2.45+df3654b377
	   |-- fabric-rendering-data-attachment-v1 0.3.34+b3afc78b77
	   |-- fabric-rendering-fluids-v1 3.0.27+b3afc78b77
	   |-- fabric-rendering-v0 1.1.48+df3654b377
	   |-- fabric-rendering-v1 3.0.7+b3afc78b77
	   |-- fabric-resource-conditions-api-v1 2.3.5+ea08f9d877
	   |-- fabric-resource-loader-v0 0.11.9+132c48c177
	   |-- fabric-screen-api-v1 2.0.7+b3afc78b77
	   |-- fabric-screen-handler-api-v1 1.3.28+b3afc78b77
	   |-- fabric-sound-api-v1 1.0.12+b3afc78b77
	   |-- fabric-transfer-api-v1 3.3.0+cdf060b277
	   \-- fabric-transitive-access-wideners-v1 4.3.0+6c31357e77
	- fabric-language-kotlin 1.10.8+kotlin.1.9.0
	   |-- org_jetbrains_kotlin_kotlin-reflect 1.9.0
	   |-- org_jetbrains_kotlin_kotlin-stdlib 1.9.0
	   |-- org_jetbrains_kotlin_kotlin-stdlib-jdk7 1.9.0
	   |-- org_jetbrains_kotlin_kotlin-stdlib-jdk8 1.9.0
	   |-- org_jetbrains_kotlinx_atomicfu-jvm 0.21.0
	   |-- org_jetbrains_kotlinx_kotlinx-coroutines-core-jvm 1.7.2
	   |-- org_jetbrains_kotlinx_kotlinx-coroutines-jdk8 1.7.2
	   |-- org_jetbrains_kotlinx_kotlinx-datetime-jvm 0.4.0
	   |-- org_jetbrains_kotlinx_kotlinx-serialization-cbor-jvm 1.5.1
	   |-- org_jetbrains_kotlinx_kotlinx-serialization-core-jvm 1.5.1
	   \-- org_jetbrains_kotlinx_kotlinx-serialization-json-jvm 1.5.1
	- fabricloader 0.14.22
	- java 17
	- megacells 2.1.0-beta.5-1.20.1
	- merequester 1.20.1-1.1.4
	   \-- midnightlib 1.2.1
	- minecraft 1.20.1
	- modmenu 7.2.1
	- roughlyenoughitems 12.0.645
	   \-- error_notifier 1.0.9
	- techreborn 5.8.5
	   |-- reborncore 5.8.5
	   |    \-- team_reborn_energy 3.0.0
	   \-- team_reborn_energy 3.0.0

Also I got this error in the log.

16:17:12.588
net.minecraft.class_1863
Render thread
Parsing error loading recipe megacells:cells/mega_mana_cell_housing
com.google.gson.JsonSyntaxException: Invalid or unsupported recipe type 'botania:terra_plate'
	at net.minecraft.class_1863.method_17875(class_1863.java:134)
	at java.base/java.util.Optional.orElseThrow(Optional.java:403)
	at net.minecraft.class_1863.method_17720(class_1863.java:134)
	at net.minecraft.class_1863.method_20705(class_1863.java:56)
	at net.minecraft.class_1863.method_18788(class_1863.java:35)
	at net.minecraft.class_4080.method_18790(class_4080.java:13)
	at java.base/java.util.concurrent.CompletableFuture$UniAccept.tryFire(CompletableFuture.java:718)
	at java.base/java.util.concurrent.CompletableFuture$Completion.run(CompletableFuture.java:482)
	at net.minecraft.class_4014.method_18365(class_4014.java:69)
	at net.minecraft.class_1255.method_18859(class_1255.java:156)
	at net.minecraft.class_4093.method_18859(class_4093.java:23)
	at net.minecraft.class_1255.method_16075(class_1255.java:130)
	at net.minecraft.class_1255.method_18857(class_1255.java:139)
	at net.minecraft.class_7196.method_45694(class_7196.java:188)
	at net.minecraft.class_7196.method_41891(class_7196.java:123)
	at net.minecraft.class_7196.method_41899(class_7196.java:202)
	at net.minecraft.class_7196.method_41894(class_7196.java:64)
	at net.minecraft.class_528$class_4272.method_20174(class_528.java:590)
	at net.minecraft.class_528$class_4272.method_20164(class_528.java:480)
	at net.minecraft.class_528$class_4272.method_25402(class_528.java:402)
	at net.minecraft.class_350.method_25402(class_350.java:327)
	at net.minecraft.class_4069.method_25402(class_4069.java:38)
	at net.minecraft.class_312.method_1611(class_312.java:98)
	at net.minecraft.class_437.method_25412(class_437.java:409)
	at net.minecraft.class_312.method_1601(class_312.java:98)
	at net.minecraft.class_312.method_22686(class_312.java:169)
	at net.minecraft.class_1255.execute(class_1255.java:102)
	at net.minecraft.class_312.method_22684(class_312.java:169)
	at org.lwjgl.glfw.GLFWMouseButtonCallbackI.callback(GLFWMouseButtonCallbackI.java:43)
	at org.lwjgl.system.JNI.invokeV(Native Method)
	at org.lwjgl.glfw.GLFW.glfwWaitEventsTimeout(GLFW.java:3474)
	at com.mojang.blaze3d.systems.RenderSystem.limitDisplayFPS(RenderSystem.java:237)
	at net.minecraft.class_310.method_1523(class_310.java:1244)
	at net.minecraft.class_310.method_1514(class_310.java:802)
	at net.minecraft.client.main.Main.main(Main.java:250)
	at net.fabricmc.loader.impl.game.minecraft.MinecraftGameProvider.launch(MinecraftGameProvider.java:468)
	at net.fabricmc.loader.impl.launch.knot.Knot.launch(Knot.java:74)
	at net.fabricmc.loader.impl.launch.knot.KnotClient.main(KnotClient.java:23)
commented

Yeah, don't worry, this is an issue entirely independent from any specific mods. I'm currently testing an adaptation made to the overall compression service to make sure it doesn't continue to bring servers to their knees.

commented

Also I got this error in the log.

This one is simply because Applied Botanics isn't present in the pack (since, of course, it isn't available yet for 1.20) and means that the recipe for the mana cell housing cannot be used. It shouldn't cause any actual problems in-game.

Ok. Thanks for all the work you have done. I enjoy playing with your mod.

commented

Yeah, don't worry, this is an issue entirely independent from any specific mods. I'm currently testing an adaptation made to the overall compression service to make sure it doesn't continue to bring servers to their knees.

That was a quick investigation and fix, thanks a lot :)

commented

As it turns out, the approach taken of having an ever-increasing multiplier was a complete disaster due to the horrendous memory requirement of using longs over ints. Instead, the old multipliers have been brought back, but with an added "1" multiplier for base items like nuggets.

commented

Reopen the issue @62832 , it still persists. However, now it happens after the server has fully started:
crash-2023-08-30_05.59.53-server.txt

commented

Sorry, I had neglected to reopen after first being informed that the issue is still persisting. I've already been working on a second iteration of the compression service since yesterday in the hopes of fixing it for good.

commented

I've pushed one more build due to release in the next 15 minutes or so. If I receive confirmation that the OOM bug is no longer present, only then will I close this issue again. Please let me know how it goes.

commented

I revoke the previous statement, issue seems not fixed. I had installed (admittedly, by own mistake) the Forge version, which removed the mod basically. After installing the Fabric version (latest release, 2.1.0-beta.7), the server hangs again immediately after startup.

I am going to install Beta.4 again, as that one worked just fine.

commented

Just for reference's sake, what pack are you currently playing on Fabric? My tests so far have been on the All The Mods 9 pack on Forge and the server proceeded just fine.

commented

Just for reference's sake, what pack are you currently playing on Fabric? My tests so far have been on the All The Mods 9 pack on Forge and the server proceeded just fine.

Personal made pack for me and my friends :)

commented

Could I get a rough mod list to test on?

commented

I'll do you a better one, you can just import the pack yourself via a modpack export I made on ATLauncher. Here you go:
https://mega.nz/file/0lFGSSya#8EMOw8SRLDGff0jxcfVTjlbpO2EMbAOZKPXO9c-85F8

Please do keep in mind, that the issue I was facing was always on the server side, not client.

commented

I seem to be unable to actually run this pack due to a JVM segfault.

In any case, since I don't think the compression rewrite has worked out for now, I'll have to revert it all and re-evaluate how to proceed with it in the end.

commented

On second thought, do you think I could reach out to you somewhere like Discord to test further? I have one or two remaining solutions for the time being that would require me to send development builds without a proper release.

commented

I seem to be unable to actually run this pack due to a JVM segfault.

In any case, since I don't think the compression rewrite has worked out for now, I'll have to revert it all and re-evaluate how to proceed with it in the end.

Damn that's interesting, works just fine for me and my friends. I could help you to get it running if you want.

On second thought, do you think I could reach out to you somewhere like Discord to test further? I have one or two remaining solutions for the time being that would require me to send development builds without a proper release.

Yea sure I do, you can reach me on Discord under (I hate the new handles, fuck Discord for that change 🤡): @lokeyourc3ph

commented

Since I have now both re-implemented compression overrides and managed to have two of the people previously reporting server crashes write back to me to say the problem is no longer present with the re-implementation, I will now be closing this issue for good.