v0.1.3 is breaking changes?

Question

iam4x opened this issue 8 years ago · comments

Hello,

We use this plugin in our babel preset (https://github.com/savemysmartphone/babel-preset-save), the minor update broke our builds.

I had to suffix the require() call to the plugin with .default see here: savemysmartphone/babel-preset-save@3c9d679

Is this normal behaviour? What happened? I can't find in the commit, this is just for personal knowledge. Thanks.

Hiroyuki Usui · Answer 1 · Tue Apr 26 2016 20:28:07 GMT+0800 (China Standard Time)

hmm... 0.1.3 no longer used the module.exports.
It has broken the compatibility of babel-presets.

iam4x · Answer 2 · Tue Apr 26 2016 20:32:35 GMT+0800 (China Standard Time)

Alright, thank's. Would be great to publish a major for breaking changes like that 👍

Jason Quense · Answer 3 · Tue Apr 26 2016 22:35:19 GMT+0800 (China Standard Time)

this plugin needs to use itself :P

Junle Li · Answer 4 · Tue Apr 26 2016 23:52:32 GMT+0800 (China Standard Time)

It is on track actually 😄 #10

Hiroyuki Usui · Answer 5 · Wed Apr 27 2016 01:18:51 GMT+0800 (China Standard Time)

this issue has been resolved in v0.1.4. thanks @iam4x 👍