Feedback
svenefftinge opened this issue · comments
This is really slick!
I just went through it and here are the rough things I noted.
2) Hello World
I used the emmet completion (type 'doc') which expands to the following:
<html lang="en">
<head>
<meta charset="UTF-8">
<meta name="viewport" content="width=device-width, initial-scale=1.0">
<meta http-equiv="X-UA-Compatible" content="ie=edge">
<title>Document</title>
</head>
<body>
</body>
</html>
After replacing the title the test still fails, because it tests on <html>. It should be more forgiving as my state is not invalid.
3) hello without head
Here I tried to see the preview, but I didn't rebuild. So the preview was empty.
Would be great if the preview button would trigger a build automatically or is disabled if there were file changes.
4)
Would make sense to advice to use https instead of http.
7)
I didn't understand the excercise. I was first creating two anchores on top and bottom
<a href="#end" id="start">go to end</a>
...
<a href="#start" id="end">go to end</a>but the tests were failing. Then I moved the ids to the h2 tags as the tests seem to expect that, but still I couldn't make the test succeed.
General
- I always opens the index.js file, although for the most part especially in the beginning the index.html is the important file. (edit: it seems like this is a race as sometimes it also reveals the html file.)