40thieves / webpack-sentry-plugin

Webpack plugin to upload source maps to Sentry

Geek Repo:Geek Repo

Github PK Tool:Github PK Tool

Release body syntax error in readme.md

lachiet opened this issue · comments

Just noticed a syntax error in the readme.

...

refs: [
    repository: 'project-repo',
    commit: process.env.GIT_SHA
]

...

should be...

...

refs: {
    repository: 'project-repo',
    commit: process.env.GIT_SHA
}

...

I think?

Ah yeah good catch. It should actually be a little of both:

refs: [{
    repository: 'project-repo',
    commit: process.env.GIT_SHA
}]

as Sentry wants an array of objects for refs. Care to send a PR?

Oh this explains why my way didn't work ha! Thanks and sure!