Giters

40thieves / webpack-sentry-plugin

Webpack plugin to upload source maps to Sentry

Geek Repo:Geek Repo

Github PK Tool:Github PK Tool

Implicit character limit for `release` parameter

codeocelot opened this issue · comments

commented

I noticed that the plugin will throw an error if provided with a full, 40 character git hash as the release parameter. This occurs if I provide a string or a function that returns a 40 character string.

I notice this error won't be thrown if I slice my git hash to 10 chars.

If this is a limitation, it would be useful to put this in the README.

Thanks,

commented

Sorry guys, my bad. I had a trailing \n on my string. I understand why parsing this out could be useful. Perhaps make the error reported more descriptive?